Do not use conda run when launching a debugger #18858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 4, 2022 15:51
This reverts commit 0ade929.
karrtikr
pushed a commit
to karrtikr/vscode-python
that referenced
this pull request
Apr 6, 2022
* Do not use conda run when launching a debugger * News * Only build VSIX * Revert "Only build VSIX" This reverts commit 0ade929.
karrtikr
pushed a commit
that referenced
this pull request
Apr 6, 2022
* Ensure `conda info` command isn't run multiple times during startup when large number of conda interpreters are present (#18808) * Wrap file paths containg an ampersand in double quotation marks for running commands in a shell (#18855) * If a conda environment is not returned via the `conda env list` command, resolve it as unknown (#18856) * If a conda environment is not returned via the conda env list command, resolve it as unknown * News entry * Fix unit tests * Do not use conda run when launching a debugger (#18858) * Do not use conda run when launching a debugger * News * Only build VSIX * Revert "Only build VSIX" This reverts commit 0ade929. * Fixes support for python binaries not following the standard names (#18860) * Fixes support for python binaries not following the standard names * news * Remove comment * Do not validate conda binaries using shell by default (#18866) * Do not validate conda binaries using shell * Fix tests * Fix lint * Fix tests * Ensure string prototypes extension extends are unique enough (#18870)
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…on#18858) * Do not use conda run when launching a debugger * News * Only build VSIX * Revert "Only build VSIX" This reverts commit 0ade929b400912a97f93099510950ba7d81779a2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18847
We get the conda executable to use using
shellExec, but theDebugAdapterExecutabledoes not use a shell when launching the executable, and hence fails. For now, the solution is to not use a conda executable when launching a debugger.Opened #18859 to investigate if it's possible to get the conda executable using
execinstead ofshellExec.