Skip to content

Drop support for Python 3.7 #21958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/actions/build-vsix/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,16 @@ runs:
using: 'composite'
steps:
- name: Install Node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ inputs.node_version }}
cache: 'npm'

# Jedi LS depends on dataclasses which is not in the stdlib in Python 3.7.
- name: Use Python 3.7 for JediLSP
uses: actions/setup-python@v2
- name: Use Python 3.8 for JediLSP
uses: actions/setup-python@v4
with:
python-version: 3.7
python-version: 3.8
cache: 'pip'
cache-dependency-path: |
requirements.txt
Expand Down Expand Up @@ -84,7 +84,7 @@ runs:
shell: bash

- name: Upload VSIX
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: ${{ inputs.artifact_name }}
path: ${{ inputs.vsix_name }}
Expand Down
4 changes: 2 additions & 2 deletions .github/actions/lint/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ runs:
using: 'composite'
steps:
- name: Install Node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ inputs.node_version }}
cache: 'npm'
Expand All @@ -36,7 +36,7 @@ runs:
shell: bash

- name: Install Python
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: '3.x'
cache: 'pip'
Expand Down
21 changes: 21 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,27 @@ updates:
labels:
- 'no-changelog'

- package-ecosystem: 'github-actions'
directory: .github/actions/build-vsix
schedule:
interval: daily
labels:
- 'no-changelog'

- package-ecosystem: 'github-actions'
directory: .github/actions/lint
schedule:
interval: daily
labels:
- 'no-changelog'

- package-ecosystem: 'github-actions'
directory: .github/actions/smoke-test
schedule:
interval: daily
labels:
- 'no-changelog'

# Not skipping the news for some Python dependencies in case it's actually useful to communicate to users.
- package-ecosystem: 'pip'
directory: /
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Build VSIX
uses: ./.github/actions/build-vsix
Expand All @@ -64,7 +64,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Lint
uses: ./.github/actions/lint
Expand All @@ -82,7 +82,7 @@ jobs:
python-version: ${{ env.PYTHON_VERSION }}

- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install core Python requirements
uses: brettcannon/pip-secure-install@v1
Expand Down Expand Up @@ -125,7 +125,7 @@ jobs:
test-suite: [ts-unit, python-unit, venv, single-workspace, multi-workspace, debugger, functional]
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
path: ${{ env.special-working-directory-relative }}

Expand Down Expand Up @@ -333,7 +333,7 @@ jobs:
os: [ubuntu-latest, windows-latest]
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Smoke tests
uses: ./.github/actions/smoke-tests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/info-needed-closer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout Actions
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: 'microsoft/vscode-github-triage-actions'
path: ./actions
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/issue-labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout Actions
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: 'microsoft/vscode-github-triage-actions'
ref: stable
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/pr-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Build VSIX
uses: ./.github/actions/build-vsix
Expand All @@ -39,7 +39,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Lint
uses: ./.github/actions/lint
Expand All @@ -56,7 +56,7 @@ jobs:
python-version: ${{ env.PYTHON_VERSION }}

- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install base Python requirements
uses: brettcannon/pip-secure-install@v1
Expand Down Expand Up @@ -100,7 +100,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
path: ${{ env.special-working-directory-relative }}

Expand Down Expand Up @@ -302,7 +302,7 @@ jobs:
steps:
# Need the source to have the tests available.
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Smoke tests
uses: ./.github/actions/smoke-tests
Expand All @@ -323,7 +323,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install Node
uses: actions/setup-node@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-plan-item-validator.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
if: contains(github.event.issue.labels.*.name, 'testplan-item') || contains(github.event.issue.labels.*.name, 'invalid-testplan-item')
steps:
- name: Checkout Actions
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: 'microsoft/vscode-github-triage-actions'
path: ./actions
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/triage-info-needed.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
if: contains(github.event.issue.labels.*.name, 'triage-needed') && !contains(github.event.issue.labels.*.name, 'info-needed')
steps:
- name: Checkout Actions
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: 'microsoft/vscode-github-triage-actions'
ref: stable
Expand All @@ -34,7 +34,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout Actions
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: 'microsoft/vscode-github-triage-actions'
ref: stable
Expand Down
11 changes: 10 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,5 +65,14 @@
"--max-line-length=88"
],
"typescript.preferences.importModuleSpecifier": "relative",
"debug.javascript.usePreview": false
"debug.javascript.usePreview": false,
// Branch name suggestion.
"git.branchRandomName.enable": true,
"git.branchProtection": [
"main",
"release/*"
],
"git.pullBeforeCheckout": true,
// Open merge editor for resolving conflicts.
"git.mergeEditor": true,
}
2 changes: 1 addition & 1 deletion build/azure-pipeline.pre-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ extends:

- task: UsePythonVersion@0
inputs:
versionSpec: '3.7'
versionSpec: '3.8'
addToPath: true
architecture: 'x64'
displayName: Select Python version
Expand Down
2 changes: 1 addition & 1 deletion build/azure-pipeline.stable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ extends:

- task: UsePythonVersion@0
inputs:
versionSpec: '3.7'
versionSpec: '3.8'
addToPath: true
architecture: 'x64'
displayName: Select Python version
Expand Down
2 changes: 1 addition & 1 deletion build/ci/conda_env_1.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: conda_env_1
dependencies:
- python=3.7
- python=3.8
- pip
Loading