Skip to content

Fix for unittest with testscenarios #23230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 18, 2024
Merged

Fix for unittest with testscenarios #23230

merged 10 commits into from
Apr 18, 2024

Conversation

karthiknadig
Copy link
Member

Fixes #17641

@karthiknadig karthiknadig self-assigned this Apr 12, 2024
@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Apr 12, 2024
@karthiknadig karthiknadig added this to the April 2024 milestone Apr 12, 2024
@karthiknadig karthiknadig marked this pull request as ready for review April 12, 2024 19:03
@karthiknadig karthiknadig marked this pull request as draft April 12, 2024 19:03
@karthiknadig karthiknadig mentioned this pull request Apr 12, 2024
Closed
eleanorjboyd
eleanorjboyd previously approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@eleanorjboyd eleanorjboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! My only concern would be releasing this into insiders the same day asa the switch to using named pipes, maybe we stagger them by a day? Not sure if this will really make a difference but in case there are issues could help narrow down where

@eleanorjboyd eleanorjboyd marked this pull request as ready for review April 17, 2024 17:31
rzhao271
rzhao271 previously approved these changes Apr 18, 2024
View reviewed changes
@eleanorjboyd eleanorjboyd requested a review from rzhao271 April 18, 2024 18:39
@eleanorjboyd eleanorjboyd merged commit f86dcb1 into microsoft:main Apr 18, 2024
35 checks passed
anthonykim1 pushed a commit to anthonykim1/vscode-python that referenced this pull request May 10, 2024
@karthiknadig @eleanorjboyd @anthonykim1
Fix for unittest with testscenarios (microsoft#23230)
86e808d 
Fixes microsoft#17641

---------

Co-authored-by: eleanorjboyd <[email protected]>
wesm pushed a commit to posit-dev/positron that referenced this pull request May 10, 2024
@karthiknadig @eleanorjboyd
Fix for unittest with testscenarios (microsoft/vscode-python#23230)
d457250 
Fixes microsoft/vscode-python#17641

---------

Co-authored-by: eleanorjboyd <[email protected]>
seeM pushed a commit to posit-dev/positron that referenced this pull request May 12, 2024
@karthiknadig @eleanorjboyd @seeM
Fix for unittest with testscenarios (microsoft/vscode-python#23230)
d1b9a20 
Fixes microsoft/vscode-python#17641

---------

Co-authored-by: eleanorjboyd <[email protected]>
wesm pushed a commit to posit-dev/positron that referenced this pull request May 13, 2024
@karthiknadig @eleanorjboyd @wesm
Fix for unittest with testscenarios (microsoft/vscode-python#23230)
4ffbdcc 
Fixes microsoft/vscode-python#17641

---------

Co-authored-by: eleanorjboyd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleanorjboyd eleanorjboyd eleanorjboyd left review comments

@connor4312 connor4312 connor4312 approved these changes

@rzhao271 rzhao271 Awaiting requested review from rzhao271

Assignees

@karthiknadig karthiknadig

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
April 2024
Development

Successfully merging this pull request may close these issues.

Unittest id parsing fails when using testscenarios
4 participants
@karthiknadig @connor4312 @rzhao271 @eleanorjboyd