Skip to content

Compute regex once in native locator #23375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2024
Merged

Compute regex once in native locator #23375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion native_locator/src/homebrew.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ pub fn find_and_report(
let homebrew_prefix = environment.get_env_var("HOMEBREW_PREFIX".to_string())?;
let homebrew_prefix_bin = PathBuf::from(homebrew_prefix).join("bin");
let mut reported: HashSet<String> = HashSet::new();
let python_regex = Regex::new(r"/(\d+\.\d+\.\d+)/").unwrap();
for file in std::fs::read_dir(homebrew_prefix_bin).ok()? {
if let Some(exe) = is_symlinked_python_executable(file) {
let python_regex = Regex::new(r"/(\d+\.\d+\.\d+)/").unwrap();
let python_version = exe.to_string_lossy().to_string();
let version = match python_regex.captures(&python_version) {
Some(captures) => match captures.get(1) {
Expand Down
Loading