Remove setting python.formatting.formatOnSave in favor of the vs code setting #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archive of 0.7.0
* 'master' of https://github.com/Microsoft/vscode-python: Fixes #56 list all environments (#219) Fixes #57 Disable activation on debugging (#220) Fixes #26 Do not run linters when linters are disabled (#222)
* upstream/master: Fix typo in README.md (#252) Disable linter without workspaces (#241)
* upstream/master: Fix feedback service (#246) Fix django context initializer (#248) disable generation of tags file upon extension load (#264)
* upstream/master: Resolve pythonPath before comparing it to shebang (#273)
* upstream/master:
Fixes #22 to Detect anaconda from known locations (#221)
Use workspaceFolder token instead of workspaceRoot (#267)
Fix registry lookup response (#224)
Fix issues when running without debugging and debugged code terminates (#249)
* upstream/master: Fix debugging tests (#304)
* upstream/master: Remove jupyter functionality in favor of Jupyter extension (#302) Drop Python 2 URLs (#307)
* master: Remove jupyter functionality in favor of Jupyter extension (#302) Drop Python 2 URLs (#307)
brettcannon
approved these changes
Nov 28, 2017
| const setting = deprecatedInfo.setting!; | ||
| let notify = false; | ||
| if (Array.isArray(workspace.workspaceFolders) && workspace.workspaceFolders.length > 0) { | ||
| workspace.workspaceFolders.forEach(wkspaceFolder => { |
There was a problem hiding this comment.
Why abbreviate wkspaceFolder for just two letters?
There was a problem hiding this comment.
oh dam, forgot workspaceFolder isn't a reserved work. Its a habit, cuz workspace is a namespace and i had abbreviated in other places to wkspace.
DonJayamanne
added a commit
that referenced
this pull request
Dec 14, 2017
* upstream/master: Remove setting python.formatting.formatOnSave in favor of the vs code setting (#312)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #285