Skip to content

Initial batch of changes to enable bundling of the extension #3384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Nov 20, 2018

Conversation

DonJayamanne
Copy link

For #3021

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [no] Has a news entry file (remember to thank yourself!)
  • [no] Unit tests & system/integration tests are added/updated
  • [no] Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@DonJayamanne DonJayamanne force-pushed the issue3021BundleExtSrcc branch from 3a09f1f to ce02e8d Compare November 19, 2018 22:54
Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can't wait to see it in action!

@DonJayamanne
Copy link
Author

DonJayamanne commented Nov 20, 2018

Looks good. Can't wait to see it in action!

Won't, until I get the YAML stuff in.
Cuz the CI and CD pipelines need to change.

  • The commands used to compile and build the extension
  • Subsequently commands used to upload
    • Cuz after all tests pass, we need to bundle using webpack
    • Run smoke tests
    • Finally upload this webpack bundled version to azure blob store
    • I.e. totally new process

@DonJayamanne DonJayamanne reopened this Nov 20, 2018
@DonJayamanne DonJayamanne reopened this Nov 20, 2018
@DonJayamanne DonJayamanne merged commit d987489 into microsoft:master Nov 20, 2018
@DonJayamanne DonJayamanne deleted the issue3021BundleExtSrcc branch December 14, 2018 22:07
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants