Skip to content

Fix all typescript errors when compiled in strict mode #1 #4410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 15, 2019

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Feb 14, 2019

For #611 part 1

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@karrtikr karrtikr requested review from DonJayamanne and removed request for DonJayamanne February 14, 2019 19:31
@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #4410 into master will increase coverage by 21%.
The diff coverage is 93%.

@@           Coverage Diff            @@
##           master   #4410     +/-   ##
========================================
+ Coverage      57%     78%    +21%     
========================================
  Files         364     439     +75     
  Lines       15495   20524   +5029     
  Branches     2408    3291    +883     
========================================
+ Hits         8752   15813   +7061     
+ Misses       6163    4707   -1456     
+ Partials      580       4    -576
Flag Coverage Δ
#Linux 66% <58%> (?)
#Windows 66% <58%> (?)
#macOS 66% <58%> (?)

@karrtikr karrtikr merged commit d014a00 into microsoft:master Feb 15, 2019
@karrtikr karrtikr deleted the errors branch February 15, 2019 16:54
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants