Common execution for python tool or module #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archive of 0.7.0
* 'master' of https://github.com/Microsoft/vscode-python: Fixes #56 list all environments (#219) Fixes #57 Disable activation on debugging (#220) Fixes #26 Do not run linters when linters are disabled (#222)
* upstream/master: Fix typo in README.md (#252) Disable linter without workspaces (#241)
* upstream/master: Fix feedback service (#246) Fix django context initializer (#248) disable generation of tags file upon extension load (#264)
* upstream/master: Resolve pythonPath before comparing it to shebang (#273)
* upstream/master:
Fixes #22 to Detect anaconda from known locations (#221)
Use workspaceFolder token instead of workspaceRoot (#267)
Fix registry lookup response (#224)
Fix issues when running without debugging and debugged code terminates (#249)
* upstream/master: Fix debugging tests (#304)
* upstream/master: Remove jupyter functionality in favor of Jupyter extension (#302) Drop Python 2 URLs (#307)
* upstream/master: Remove setting python.formatting.formatOnSave in favor of the vs code setting (#312)
* upstream/master: Remove setting linting.lintOnTextChange as it was never implemented (#315)
* upstream/master: Fix travis build error (#326)
* upstream/master: add new npm deps with improved gulp for dev (#328)
* upstream/master: Update version of inversify package (#329)
* upstream/master: Document our dev process (#330)
* upstream/master: Document contribution to the code along with coding standards (#321)
* upstream/master: Add Simplified Chinese translation of commands (#240)
* upstream/master: Fix package.json (#347)
* upstream/master: #34, #110 - suppress Intellisense in strings and comments (#339) Re-factor code python execution framework (#345)
* upstream/master: Fix linters to make use of the new python code execution framework (#360) Update the versioning scheme (#356) Make npm happy in regards to line endings (#357)
* upstream/master: Ensure python path is not set if already set in user settings (#369) Use 'an' rather than 'a' before vowel words (#373)
* upstream/master: Use new environment variable parser (#362)
* RefactorJediAndOthers: Fixed code review comments
* upstream/master: Release 0.9.1 (#458) Add localization for Japanese (#434) Add Svn to uriSchemesToIgnore (#443)
* EnvVarFixes: add missing service registrations
* EnvVarFixes: add missing service registration
* EnvVarFixes: remove imports of 'reflect-metadata'
DonJayamanne
changed the title
* upstream/master: Refactor parsing of environment variables (after 439) (#466) Refactor extension to remove old way of spawning python processes (#439)
|
@MikhailArkhipov please could you review this? |
| promise = pythonExecutionServicePromise.then(executionService => { | ||
| return executionService.execModuleObservable(moduleName, options.args, { ...spawnOptions }); | ||
| }); | ||
| const pythonToolsExecutionService = serviceContainer.get<IPythonToolExecutionService>(IPythonToolExecutionService); |
There was a problem hiding this comment.
Up to you, but I think there is an option to derive PythonTestExecutionService, override handling and push instance in the test service registry. This way you won't have to have test code in the main module.
MikhailArkhipov
approved these changes
Jan 3, 2018
|
BTW, we are getting some lint failures in Travis |
DonJayamanne
added a commit
that referenced
this pull request
Jan 9, 2018
* upstream/master: Common execution for python tool or module (#468)
DonJayamanne
added a commit
that referenced
this pull request
Jan 9, 2018
* CompleteCodeExec: Common execution for python tool or module (#468)
DonJayamanne
added a commit
that referenced
this pull request
Jan 9, 2018
* YarnAndCodeCoverage: remove unwanted files Common execution for python tool or module (#468)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #456