Skip to content

Conda activation fails when there is a space in the env name #4717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2019

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Mar 12, 2019

For #4273

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [x] Has sufficient logging.
  • [x] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [x] Test plan is updated as appropriate
  • [x] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [x] The wiki is updated with any design decisions/details.

@karrtikr karrtikr requested a review from DonJayamanne March 12, 2019 00:13
@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #4717 into master will increase coverage by 1%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4717   +/-   ##
======================================
+ Coverage      77%     77%   +1%     
======================================
  Files         447     447           
  Lines       21459   21459           
  Branches     3524    3524           
======================================
+ Hits        16427   16430    +3     
+ Misses       5028    5025    -3     
  Partials        4       4
Flag Coverage Δ
#Linux 66% <ø> (ø) ⬇️
#Windows 66% <ø> (ø) ⬇️
#macOS 65% <ø> (ø) ⬇️

@DonJayamanne DonJayamanne merged commit b24407b into microsoft:master Mar 12, 2019
@karrtikr karrtikr deleted the fixCondaActivation branch March 12, 2019 18:13
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants