Skip to content

Allows test discovery when flake8-plugin to pytest is set to run #5491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

mdavezac
Copy link

@mdavezac mdavezac commented Apr 26, 2019

I've set my repo to run flake8 automatically via setup.cfg flags to pytest.
It uncovered two issues in the pytest adapter:

  • item.hasattr(x) called rather than hasattr(item, x), however item may not have a hasattr method.
  • also uncovered a path where the testfunc variable is never defined.

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@msftclas
Copy link

msftclas commented Apr 26, 2019

CLA assistant check
All CLA requirements met.

@brettcannon
Copy link
Member

I just wanted to say a quick "thanks" for the PR, @mdavezac , and we plan to try and get to this early next week.

@brettcannon
Copy link
Member

@mdavezac Quick update: basically PyCon and a week-long event at Microsoft ate up the team's time more than we expected. And now @ericsnowcurrently is out until next week, so it's still going to be a little while until we get to this. I apologize for the delay.

@ericsnowcurrently
Copy link

Thanks again for the PR, @mdavezac. We have another PR (#5648) that fixes this in a slightly different way, along with a bunch of other small fixes.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants