Skip to content

Added ability to auto update Insiders build of extension #6308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Jul 11, 2019
Merged

Added ability to auto update Insiders build of extension #6308

merged 33 commits into from
Jul 11, 2019

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Jun 24, 2019 •
edited
Loading

For #2772

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • ~[ ] Appropriate comments and documentation strings in the code
  • ~[ ] Has sufficient logging.
  • ~[ ] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • ~[ ] Test plan is updated as appropriate
  • ~[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

rchiodo
rchiodo reviewed Jun 24, 2019
View reviewed changes
rchiodo
rchiodo reviewed Jun 24, 2019
View reviewed changes
@karrtikr karrtikr force-pushed the insiders branch 11 times, most recently from 7d5a452 to 318392b Compare July 1, 2019 03:22
DonJayamanne
DonJayamanne reviewed Jul 1, 2019
View reviewed changes
@karrtikr karrtikr force-pushed the insiders branch 2 times, most recently from 178bcc3 to 64f5797 Compare July 1, 2019 19:41
DonJayamanne
DonJayamanne previously requested changes Jul 1, 2019
View reviewed changes
@karrtikr karrtikr closed this Jul 2, 2019
@karrtikr karrtikr reopened this Jul 2, 2019
@WSLUser
Copy link

WSLUser commented Jul 3, 2019

Could this include automatically configuring the setting for using Insiders of the Intellisense Language Server? That would be useful. It could be a separate PR as a sub-option as well.

@karrtikr
Copy link
Author

karrtikr commented Jul 3, 2019

@WSLUser We will have to make a decision on that, could please open up a new issue for this?

@WSLUser WSLUser mentioned this pull request Jul 5, 2019
Closed
@karrtikr karrtikr force-pushed the insiders branch 4 times, most recently from fb4af92 to ea37f76 Compare July 9, 2019 22:27
@karrtikr karrtikr changed the title WIP - Added ability to auto update Insiders build of extension Added ability to auto update Insiders build of extension Jul 10, 2019
@karrtikr karrtikr requested a review from DonJayamanne July 10, 2019 00:21
@karrtikr karrtikr merged commit e19dba8 into microsoft:master Jul 11, 2019
@karrtikr karrtikr deleted the insiders branch July 11, 2019 01:21
@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rchiodo rchiodo rchiodo left review comments

@DonJayamanne DonJayamanne DonJayamanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karrtikr @WSLUser @DonJayamanne @rchiodo