Skip to content

Fix code lens bug + added some tests #6782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Jul 30, 2019

For #6303

This is effectively an un-revert of #6755 (reverted in #6780), with testing fixes.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

Copy link

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is different from #6755? Is it only that you are no longer ignoring roots that do not match the current workspace? Why did you remove that part?

(otherwise looks good)

@ericsnowcurrently ericsnowcurrently self-requested a review July 31, 2019 18:43
@karrtikr
Copy link
Author

What is different from #6755? Is it only that you are no longer ignoring roots that do not match the current workspace? Why did you remove that part?

(otherwise looks good)

@ericsnowcurrently Yes, current workspace path is not related to data root paths at all. Because test root paths can be anything, as you explained. So removed that entire check, where I was only considering data roots which are equal to workspace root.

@ericsnowcurrently
Copy link

We should still ensure that the test root is under the workspace folder, even if it isn't equal.

@karrtikr
Copy link
Author

karrtikr commented Jul 31, 2019

@ericsnowcurrently But that seems unrelated to this issue, right? Would prefer to do it separately if that's the case.

Also, even if tests are outside the workspace, why not discover those tests as well?

@ericsnowcurrently
Copy link

I've opened #6820 for dealing with the test roots.

Copy link

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karrtikr karrtikr merged commit 78848ad into microsoft:master Aug 1, 2019
@karrtikr karrtikr deleted the fixcodelens branch August 1, 2019 18:26
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants