Skip to content

Don't prompt to update inheritEnv when on Windows #7901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2019

Conversation

kimadeline
Copy link

For #7607

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@kimadeline kimadeline added the no-changelog No news entry required label Oct 10, 2019
@codecov-io
Copy link

codecov-io commented Oct 10, 2019

Codecov Report

Merging #7901 into master will decrease coverage by 0.35%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7901      +/-   ##
==========================================
- Coverage   58.93%   58.58%   -0.36%     
==========================================
  Files         498      498              
  Lines       22293    21936     -357     
  Branches     3575     3576       +1     
==========================================
- Hits        13139    12851     -288     
+ Misses       8332     8263      -69     
  Partials      822      822
Impacted Files Coverage Δ
src/client/common/utils/localize.ts 94.01% <100%> (ø) ⬆️
...t/interpreter/virtualEnvs/condaInheritEnvPrompt.ts 98.24% <100%> (+0.13%) ⬆️
...nt/datascience/jupyter/invalidNotebookFileError.ts 0% <0%> (-75%) ⬇️
.../client/datascience/jupyter/jupyterConnectError.ts 0% <0%> (-66.67%) ⬇️
...science/jupyter/jupyterKernelPromiseFailedError.ts 0% <0%> (-50%) ⬇️
...ent/datascience/jupyter/jupyterWaitForIdleError.ts 0% <0%> (-50%) ⬇️
src/client/language/characters.ts 12% <0%> (-18.77%) ⬇️
src/client/constants.ts 75% <0%> (-5%) ⬇️
src/client/datascience/cellFactory.ts 72.34% <0%> (-3.53%) ⬇️
...lient/datascience/jupyter/jupyterSelfCertsError.ts 100% <0%> (ø) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dba0e4...bd549d8. Read the comment docs.

@kimadeline kimadeline marked this pull request as ready for review October 10, 2019 19:51
Copy link

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kimadeline kimadeline merged commit 73b5937 into microsoft:master Oct 10, 2019
@kimadeline kimadeline deleted the 7607-flip-inherit-env-conda branch October 10, 2019 21:36
@lock lock bot locked as resolved and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants