Skip to content

Fix gulp task where args passed to spawnAsync in installNewPtvsd was wrong #8871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2019
Merged

Fix gulp task where args passed to spawnAsync in installNewPtvsd was wrong #8871

merged 1 commit into from
Dec 5, 2019

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Dec 2, 2019 •
edited
Loading

For #8606

@karthiknadig karthiknadig added the no-changelog No news entry required label Dec 2, 2019
@karthiknadig karthiknadig requested a review from karrtikr December 2, 2019 23:36
@codecov-io
Copy link

codecov-io commented Dec 2, 2019 •
edited
Loading

Codecov Report

Merging #8871 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8871   +/-   ##
=======================================
  Coverage   57.36%   57.36%           
=======================================
  Files         527      527           
  Lines       27198    27198           
  Branches     4146     4146           
=======================================
  Hits        15601    15601           
  Misses      10720    10720           
  Partials      877      877

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8bd87e...3df8db7. Read the comment docs.

@karthiknadig karthiknadig mentioned this pull request Dec 3, 2019
Closed
@karthiknadig karthiknadig merged commit 9449a2e into microsoft:master Dec 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 12, 2019
@karthiknadig karthiknadig deleted the fixgulp branch December 27, 2019 02:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karrtikr karrtikr karrtikr approved these changes

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karthiknadig @codecov-io @karrtikr