Skip to content

Bind function to class instance in middleware #9109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Bind function to class instance in middleware #9109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f827f3
Bind function to class
Dec 13, 2019
29318b9
Add news
Dec 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/2 Fixes/9096.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix issue that prevented language server diagnostics from being published.
1 change: 1 addition & 0 deletions src/client/activation/languageServer/languageClientMiddleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ export class LanguageClientMiddleware implements Middleware {
private connected = false; // Default to not forwarding to VS code.

public constructor(private readonly surveyBanner: IPythonExtensionBanner) {
this.handleDiagnostics = this.handleDiagnostics.bind(this); // VS Code calls function without context.
}

public connect() {
Expand Down