Skip to content

Skip a few platform-related tests for CI failures (for now). #9354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 2, 2020

Conversation

ericsnowcurrently
Copy link

(for #8995)

This PR temporarily disables some failing functional tests (but only on the failing platforms). The tests were added in PR #9170. We will fix them ASAP, but in the meantime still have coverage on other platforms.

@ericsnowcurrently ericsnowcurrently added the no-changelog No news entry required label Jan 1, 2020
@codecov-io
Copy link

codecov-io commented Jan 1, 2020

Codecov Report

Merging #9354 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #9354   +/-   ##
======================================
  Coverage    60.2%   60.2%           
======================================
  Files         544     544           
  Lines       28620   28620           
  Branches     4333    4333           
======================================
  Hits        17232   17232           
+ Misses      10460   10453    -7     
- Partials      928     935    +7
Impacted Files Coverage Δ
src/client/common/utils/version.ts 81.48% <0%> (ø) ⬆️
.../client/datascience/jupyter/jupyterConnectError.ts 75% <0%> (ø) ⬆️
src/client/datascience/cellFactory.ts 71.25% <0%> (ø) ⬆️
src/client/language/characters.ts 94.28% <0%> (ø) ⬆️
src/client/providers/providerUtilities.ts 88.88% <0%> (ø) ⬆️
src/client/constants.ts 80% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38122f3...cc5006f. Read the comment docs.

@ericsnowcurrently ericsnowcurrently changed the title Fix fs ci Skip a few platform-related tests for CI failures (for now). Jan 1, 2020
@ericsnowcurrently
Copy link
Author

Assuming this change looks good, feel free to merge this after reviewing. I'm out another week still.

@karrtikr karrtikr merged commit 4237a55 into microsoft:master Jan 2, 2020
@ericsnowcurrently ericsnowcurrently deleted the fix-fs-ci branch January 2, 2020 17:41
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants