Skip to content

If sockets are not supported, do not run socket test #9364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 2, 2020

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Jan 2, 2020

For #9360

@karrtikr karrtikr added the no-changelog No news entry required label Jan 2, 2020
@codecov-io
Copy link

codecov-io commented Jan 2, 2020

Codecov Report

Merging #9364 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9364      +/-   ##
==========================================
- Coverage   60.33%   60.04%   -0.29%     
==========================================
  Files         545      545              
  Lines       28668    28668              
  Branches     4345     4340       -5     
==========================================
- Hits        17296    17215      -81     
- Misses      10436    10517      +81     
  Partials      936      936
Impacted Files Coverage Δ
src/client/testing/serviceRegistry.ts 49.09% <0%> (-47.28%) ⬇️
src/client/testing/codeLenses/main.ts 40% <0%> (-30%) ⬇️
src/client/datascience/jupyter/jupyterUtils.ts 61.11% <0%> (-27.78%) ⬇️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 50% <0%> (-25%) ⬇️
src/client/formatters/serviceRegistry.ts 75% <0%> (-25%) ⬇️
...ience/jupyter/jupyterDebuggerRemoteNotSupported.ts 60% <0%> (-20%) ⬇️
...cience/jupyter/jupyterDebuggerNotInstalledError.ts 50% <0%> (-16.67%) ⬇️
src/client/common/utils/icons.ts 83.33% <0%> (-16.67%) ⬇️
src/client/api.ts 78.57% <0%> (-14.29%) ⬇️
src/client/datascience/cellFactory.ts 59.52% <0%> (-11.91%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b6a8f2...ede08c7. Read the comment docs.

@karrtikr karrtikr reopened this Jan 2, 2020
@karrtikr karrtikr merged commit 170375f into microsoft:master Jan 2, 2020
@karrtikr karrtikr deleted the skipFStest branch January 2, 2020 20:48
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants