Skip to content

Bypass conda service when creating daemons #9454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2020

Conversation

DonJayamanne
Copy link

Related to #9444
(do not use conda service conda run when starting the daemon)

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Jan 8, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo
Copy link

rchiodo commented Jan 8, 2020

I'm a little nervous with this one. What bug is causing you to make this change? conda run is working for me on my machine.

@DonJayamanne
Copy link
Author

I'm a little nervous with this one. What bug is causing you to make this change? conda run is working for me on my machine.

Today the daemon works using activated environmen variables. However if the daemon is busy we fall back to the regular python process. This will end up using conda run.
The new change ensures that it doesn't use conda run, but only uses activated environment variables.

@codecov-io
Copy link

codecov-io commented Jan 8, 2020

Codecov Report

Merging #9454 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9454      +/-   ##
==========================================
+ Coverage   60.91%   60.91%   +<.01%     
==========================================
  Files         530      530              
  Lines       28650    28650              
  Branches     4344     4344              
==========================================
+ Hits        17451    17452       +1     
+ Misses      10246    10245       -1     
  Partials      953      953
Impacted Files Coverage Δ
src/client/datascience/jupyter/notebookStarter.ts 71.54% <ø> (ø) ⬆️
src/client/common/utils/platform.ts 76.47% <0%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f943f26...bde5a0b. Read the comment docs.

@DonJayamanne DonJayamanne merged commit a734c63 into microsoft:master Jan 8, 2020
DonJayamanne added a commit that referenced this pull request Jan 8, 2020
@kimadeline kimadeline mentioned this pull request Jan 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
@DonJayamanne DonJayamanne deleted the bypassConda branch April 30, 2020 16:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants