Skip to content

Factor out RawFileSystem. #9499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 27, 2020
Merged

Conversation

ericsnowcurrently
Copy link

@ericsnowcurrently ericsnowcurrently commented Jan 9, 2020

(for #8995)

This separates the low-level filesystem operations from the high-level "fs utils". The move to the VS Code FS API can then happen strictly inside RawFileSystem. Also, this is part of what we reverted in #8970.

Note that the bulk of the changes are in test code. Also, of the non-test code, the changes are either just moving things around (from FileSystem to RawFileSystem), or adding the new RawFileSystem class (and IRawFileSystem interface).

@ericsnowcurrently ericsnowcurrently added the no-changelog No news entry required label Jan 9, 2020
@codecov-io
Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #9499 into master will decrease coverage by 0.6%.
The diff coverage is 57.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9499      +/-   ##
==========================================
- Coverage   60.79%   60.19%   -0.61%     
==========================================
  Files         551      556       +5     
  Lines       29666    31842    +2176     
  Branches     4486     5138     +652     
==========================================
+ Hits        18036    19167    +1131     
- Misses      10620    11589     +969     
- Partials     1010     1086      +76
Impacted Files Coverage Δ
src/client/common/platform/types.ts 100% <ø> (ø) ⬆️
src/client/common/platform/fileSystem.ts 58.67% <57.74%> (+32.86%) ⬆️
...ence/interactive-common/intellisense/conversion.ts 30.61% <0%> (-8.52%) ⬇️
src/client/common/terminal/service.ts 86.76% <0%> (-5.97%) ⬇️
src/client/activation/refCountedLanguageServer.ts 34.78% <0%> (-5.22%) ⬇️
src/client/common/terminal/factory.ts 91.3% <0%> (-5.13%) ⬇️
...atascience/interactive-window/interactiveWindow.ts 14.21% <0%> (-4.45%) ⬇️
src/client/common/asyncDisposableRegistry.ts 18.18% <0%> (-4.05%) ⬇️
src/client/sourceMapSupport.ts 78.72% <0%> (-2.13%) ⬇️
src/client/activation/jedi.ts 19.81% <0%> (-2.07%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8e7ee...8c1d3be. Read the comment docs.

ericsnowcurrently added a commit that referenced this pull request Jan 22, 2020
(for #8895)

This change helps simplify the changes in #9499.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 1 Security Hotspot to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ericsnowcurrently ericsnowcurrently merged commit a6da8d3 into microsoft:master Jan 27, 2020
@ericsnowcurrently ericsnowcurrently deleted the fs-raw branch January 27, 2020 20:36
@lock lock bot locked as resolved and limited conversation to collaborators Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants