-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Factor out RawFileSystem. #9499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factor out RawFileSystem. #9499
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9499 +/- ##
==========================================
- Coverage 60.79% 60.19% -0.61%
==========================================
Files 551 556 +5
Lines 29666 31842 +2176
Branches 4486 5138 +652
==========================================
+ Hits 18036 19167 +1131
- Misses 10620 11589 +969
- Partials 1010 1086 +76
Continue to review full report at Codecov.
|
a0cc33c
to
68762f5
Compare
(for #8895) This change helps simplify the changes in #9499.
68762f5
to
aa09387
Compare
Kudos, SonarCloud Quality Gate passed!
|
(for #8995)
This separates the low-level filesystem operations from the high-level "fs utils". The move to the VS Code FS API can then happen strictly inside RawFileSystem. Also, this is part of what we reverted in #8970.
Note that the bulk of the changes are in test code. Also, of the non-test code, the changes are either just moving things around (from
FileSystem
toRawFileSystem
), or adding the newRawFileSystem
class (andIRawFileSystem
interface).