Skip to content

Factor out FileSystemUtils #9808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jan 30, 2020

Conversation

ericsnowcurrently
Copy link

(for #8995)

This is one of the last parts to be un-reverted for the FS changes.

Note that most of the PR is tests. The changes in fileSystem.ts are mostly just moving code around.

@ericsnowcurrently ericsnowcurrently added the no-changelog No news entry required label Jan 28, 2020
@codecov-io
Copy link

codecov-io commented Jan 28, 2020

Codecov Report

Merging #9808 into master will increase coverage by 0.15%.
The diff coverage is 56.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9808      +/-   ##
==========================================
+ Coverage   60.87%   61.02%   +0.15%     
==========================================
  Files         556      556              
  Lines       30043    30074      +31     
  Branches     4555     4556       +1     
==========================================
+ Hits        18290    18354      +64     
+ Misses      10726    10694      -32     
+ Partials     1027     1026       -1
Impacted Files Coverage Δ
src/client/common/platform/types.ts 100% <ø> (ø) ⬆️
src/client/common/platform/fileSystem.ts 76.08% <56.04%> (+19.3%) ⬆️
src/client/common/platform/fs-paths.ts 76.92% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ef1aa...df07eb5. Read the comment docs.

Copy link
Member

@karthiknadig karthiknadig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 1 Security Hotspot to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ericsnowcurrently ericsnowcurrently merged commit 2b34212 into microsoft:master Jan 30, 2020
@ericsnowcurrently ericsnowcurrently deleted the fs-utils branch January 30, 2020 23:22
@lock lock bot locked as resolved and limited conversation to collaborators Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants