Skip to content

Use the VS Code FS API in RawFileSystem. #9846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 10, 2020

Conversation

ericsnowcurrently
Copy link

@ericsnowcurrently ericsnowcurrently commented Jan 30, 2020

(for #8995)

This is the last part of un-reverting the FS changes.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Jan 31, 2020

Codecov Report

Merging #9846 into master will increase coverage by <.01%.
The diff coverage is 98.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9846      +/-   ##
==========================================
+ Coverage   61.21%   61.22%   +<.01%     
==========================================
  Files         564      564              
  Lines       30152    30192      +40     
  Branches     4561     4567       +6     
==========================================
+ Hits        18458    18484      +26     
- Misses      10659    10675      +16     
+ Partials     1035     1033       -2
Impacted Files Coverage Δ
src/client/common/platform/types.ts 100% <ø> (ø) ⬆️
src/client/common/platform/fs-temp.ts 100% <ø> (ø) ⬆️
src/client/common/platform/fileSystem.ts 80.97% <100%> (+3.75%) ⬆️
src/client/common/platform/errors.ts 98.36% <88.88%> (-1.64%) ⬇️
src/client/common/utils/platform.ts 70.58% <0%> (-5.89%) ⬇️
src/client/datascience/jupyter/jupyterNotebook.ts 4.38% <0%> (-0.18%) ⬇️
...ient/datascience/interactive-ipynb/nativeEditor.ts 56.86% <0%> (-0.13%) ⬇️
src/client/common/platform/fs-paths.ts 80.76% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f6a003...0d1d4a1. Read the comment docs.

@ericsnowcurrently ericsnowcurrently force-pushed the fs-new-api branch 2 times, most recently from 4ac713b to 8163d7a Compare February 10, 2020 20:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ericsnowcurrently ericsnowcurrently merged commit e7e9de5 into microsoft:master Feb 10, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 17, 2020
@ericsnowcurrently ericsnowcurrently deleted the fs-new-api branch April 8, 2020 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants