Skip to content

Weird vertical gap between input and results in test view #188841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyceerhl opened this issue Jul 25, 2023 · 5 comments · Fixed by #189441
Closed

Weird vertical gap between input and results in test view #188841

joyceerhl opened this issue Jul 25, 2023 · 5 comments · Fixed by #189441
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue testing Built-in testing support verified Verification succeeded
Milestone

Comments

@joyceerhl
Copy link
Contributor

Testing microsoft/vscode-python#13301

None of the other views which have inputs at the top have a gap like this, not sure if this is specific to Pytest:

image
@connor4312
Copy link
Member

That's from #188484, and it goes away(/is filled) once tests are run for the first time. I'm happy to hear other ideas for that area. Or maybe we can indicate state in ways that don't require showing text there...

@eleanorjboyd
Copy link
Member

I think a better solution would be to display this text differently to notify the issuer. I think the fact that it says pytest discovery as part of the dropdown is weird to begin with. Might be worth spending time doing a further investigation in ways to display testing errors to users. @connor4312 would be interested to know if you have any ideas. Otherwise, this would be something I can explore following the rewrite and some more pressing performance issues.

@connor4312
Copy link
Member

connor4312 commented Jul 31, 2023

I think I want to put some kind of less-literal display of text there. Something like

[ Filter box here          ]
❌ 123/126             12.4s
                       ^ timer counts up as tests run
^ tooltip "123 of 126 tests passed"

Then text "waiting for a test run" when there wasn't any previous test run.

I think the pytest discovery error is not what Joyce was talking about here, but I'm happy to hear ideas to improve it.

@eleanorjboyd
Copy link
Member

understood thank you! I think a display like that would be great

@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue testing Built-in testing support labels Aug 1, 2023
connor4312 added a commit that referenced this issue Aug 2, 2023
With results, the area is both more compact and useful. Passed/Total
tests are shown on the left, with an icon summarizing the view. On the
right, the wall-clock duration of the tests and a button to rerun tests.
The alt action on the button reruns the tests with the debugger.
Previously the rerun action was not very discoverable--had a few issues
about it over the course of time.

![](https://memes.peet.io/img/23-08-8bb85d55-6304-4acb-bef3-9c1126da8c49.png)

There's also no awkward gap when there's no test results:

![](https://memes.peet.io/img/23-08-f5bcda56-60d7-4c8d-9822-e311b68079d7.png)

Fixes #188841

cc @eleanorjboyd
connor4312 added a commit that referenced this issue Aug 2, 2023
With results, the area is both more compact and useful. Passed/Total
tests are shown on the left, with an icon summarizing the view. On the
right, the wall-clock duration of the tests and a button to rerun tests.
The alt action on the button reruns the tests with the debugger.
Previously the rerun action was not very discoverable--had a few issues
about it over the course of time.

![](https://memes.peet.io/img/23-08-8bb85d55-6304-4acb-bef3-9c1126da8c49.png)

There's also no awkward gap when there's no test results:

![](https://memes.peet.io/img/23-08-f5bcda56-60d7-4c8d-9822-e311b68079d7.png)

Fixes #188841

cc @eleanorjboyd
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Aug 2, 2023
@vscodenpa vscodenpa added this to the August 2023 milestone Aug 2, 2023
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 3, 2023
@karthiknadig
Copy link
Member

Verified
image

@karthiknadig karthiknadig added the verified Verification succeeded label Aug 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue testing Built-in testing support verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants