-
Notifications
You must be signed in to change notification settings - Fork 32.8k
Weird vertical gap between input and results in test view #188841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
That's from #188484, and it goes away(/is filled) once tests are run for the first time. I'm happy to hear other ideas for that area. Or maybe we can indicate state in ways that don't require showing text there... |
I think a better solution would be to display this text differently to notify the issuer. I think the fact that it says pytest discovery as part of the dropdown is weird to begin with. Might be worth spending time doing a further investigation in ways to display testing errors to users. @connor4312 would be interested to know if you have any ideas. Otherwise, this would be something I can explore following the rewrite and some more pressing performance issues. |
I think I want to put some kind of less-literal display of text there. Something like
Then text "waiting for a test run" when there wasn't any previous test run. I think the pytest discovery error is not what Joyce was talking about here, but I'm happy to hear ideas to improve it. |
understood thank you! I think a display like that would be great |
With results, the area is both more compact and useful. Passed/Total tests are shown on the left, with an icon summarizing the view. On the right, the wall-clock duration of the tests and a button to rerun tests. The alt action on the button reruns the tests with the debugger. Previously the rerun action was not very discoverable--had a few issues about it over the course of time.  There's also no awkward gap when there's no test results:  Fixes #188841 cc @eleanorjboyd
With results, the area is both more compact and useful. Passed/Total tests are shown on the left, with an icon summarizing the view. On the right, the wall-clock duration of the tests and a button to rerun tests. The alt action on the button reruns the tests with the debugger. Previously the rerun action was not very discoverable--had a few issues about it over the course of time.  There's also no awkward gap when there's no test results:  Fixes #188841 cc @eleanorjboyd
Testing microsoft/vscode-python#13301
None of the other views which have inputs at the top have a gap like this, not sure if this is specific to Pytest:
The text was updated successfully, but these errors were encountered: