'reindent all lines' and formatter have different formatting strategies

[aeschli]

Testing #19091
In a typescript file:

class B {
	public foo() {
		console.log('hello');
		switch (parseInt(this.toString())) {
			case 1: 
				break;
			case 2:
				break;
		}
	}
}

• use 'Reindent All Lines'
• Indenting of the 'break' statements is changed to align to the case statements
• Use the formatter: break statements are indented again

It would be better if formatter and the reindent command use the same indentation strategy.

[rebornix]

This is because that our indentation rules for TypeScript is not complete, the one we are using is

decreaseIndentPattern: /^(.*\*\/)?\s*\}.*$/,
increaseIndentPattern: /^.*\{[^}"']*$/

The one TextMate or other editors are using is like

decreaseIndentPattern: /^\s*((?!\S.*\/[*]).*[*]\/\s*)?[})\]]|^\s*(case\b.*|default):\s*(\/\/.*|\/[*].*[*]\/\s*)?$/,
increaseIndentPattern: /(\{[^}"']*|\([^)"']*|\[[^\]"']*|^\s*(\{\}|\(\)|\[\]|(case\b.*|default):))\s*(\/\/.*|\/[*].*[*]\/\s*)?$/,
indentNextLinePattern: /^\s*(for|while|if|else)\b(?!.*[;{}]\s*(\/\/.*|\/[*].*[*]\/\s*)?$)/,
unIndentedLinePattern: /^(?!.*([;{}]|\S:)\s*(\/\/.*|\/[*].*[*]\/\s*)?$)(?!.*(\{[^}"']*|\([^)"']*|\[[^\]"']*|^\s*(\{\}|\(\)|\[\]|(case\b.*|default):))\s*(\/\/.*|\/[*].*[*]\/\s*)?$)(?!^\s*((?!\S.*\/[*]).*[*]\/\s*)?[})\]]|^\s*(case\b.*|default):\s*(\/\/.*|\/[*].*[*]\/\s*)?$)(?!^\s*(for|while|if|else)\b(?!.*[;{}]\s*(\/\/.*|\/[*].*[*]\/\s*)?$))/

But we still have good experience with TypeScript as we allow extensions to customize onEnterRules, the indentation adjusts correctly for most of the case when users press enter.

Right now Reindent lines only read indentation rules and doesn't take onEnter rules into consideration as at least for TypeScript there are a few overlap between the second indentation rules set and onEnterRules.

I suggest to make ReIndent Lines honor onEnterRules and remove unnecessary onEnterRules from TypeScript. cc @mjbvz . Since it's kind of breaking change I'd like to postpone it to following iteration and work together with Matt.

[Nimzozo]

A case label is not a statement and should not be indented, but aligned with the switch.

[wuhkuh]

Other issues have been closed in favor of this one, but this issue has gone stale. Could you give us an update?

[mjbvz]

Changing switch/case indentation for the JS/ts formatter is tracked by microsoft/TypeScript#18682