Skip to content

Add vscode.workspace.fs.mkdirp(). #84516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericsnowcurrently opened this issue Nov 11, 2019 · 2 comments
Closed

Add vscode.workspace.fs.mkdirp(). #84516

ericsnowcurrently opened this issue Nov 11, 2019 · 2 comments
Assignees
Labels
file-io File I/O polish Cleanup and polish issue

Comments

@ericsnowcurrently
Copy link

(see #84175)

For the Python extension, we had been using fs-extra's mkdirp(), though we could have used node's mkdir() with the recursive: true option. T he new filesystem API provides createDirectory(), but that fails if the parent directory is missing. So we wrote a wrapper around that. However, it isn't an obvious solution, so it would be nice if the extension provided the equivalent of mkdirp().

@jrieken

@jrieken
Copy link
Member

jrieken commented Nov 12, 2019

fs.createDirectory does this, I will update the docs

@jrieken jrieken added file-io File I/O polish Cleanup and polish issue labels Nov 12, 2019
@jrieken jrieken closed this as completed Nov 12, 2019
jrieken added a commit that referenced this issue Nov 12, 2019
@ericsnowcurrently
Copy link
Author

ericsnowcurrently commented Nov 12, 2019

Thanks, @jrieken! Yeah, the docs basically say the exact opposite. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
file-io File I/O polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

2 participants