Simpler bindings generation #3367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChrisDenton just fyi - no need to do this for rust-lang but its an option if you find its simpler to maintain. |
|
It does look much simpler both for contributors and maintainers. Not least because it won't break if something is moved to another namespace. |
|
Yep, that's a good point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to #3359, bindings for Win32 APIs can mostly ignore the artificial namespaces imposed by the metadata format. This simplifies the maintenance of binding generation scripts.
All I've done here is (1) remove the explicit namespace for types and (2) sorted alphabetically.