Skip to content

Conversation

VipinDevelops
Copy link
Contributor

@VipinDevelops VipinDevelops commented Jun 9, 2024

Linked Issue(s)

#398

Acceptance Criteria fulfillment

  • When sorting Reviewers, the number of reviewers is the primary sort, and alphabetically after that

Proposed changes (including videos or screenshots)

Before

image

After

image

@CLAassistant
Copy link

CLAassistant commented Jun 9, 2024

CLA assistant check
All committers have signed the CLA.

@VipinDevelops
Copy link
Contributor Author

Hey, @e-for-eshaan Can you please take a look at this PR,
To solve the error, I used the spread operator ([...]) to create a shallow copy of the pr.reviewers array before sorting it, preventing the mutation of the original array.

Copy link
Member

@jayantbh jayantbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Congrats on getting this merged, sire!

@jayantbh jayantbh merged commit 800adc3 into middlewarehq:main Jun 14, 2024
@VipinDevelops
Copy link
Contributor Author

VipinDevelops commented Jun 15, 2024

LGTM! Congrats on getting this merged, sire!

Thanks for merging this :) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants