Skip to content

run docker compose build before running docker compose watch to sync any local files changes between container restarts #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2024
Merged

run docker compose build before running docker compose watch to sync any local files changes between container restarts #435

merged 2 commits into from
Jun 18, 2024

Conversation

adnanhashmi09
Copy link
Contributor

@adnanhashmi09 adnanhashmi09 commented Jun 18, 2024 •
edited
Loading

Linked Issue(s)

#353

This PR fixes the above linked issue. We run docker compose build before starting the docker compose watch which would rebuild the container with local changes.

Steps to check

  1. Run dev.sh to start the dev cli
  2. Make local code changes and check if those has been synced and the changes are reflected in the app
  3. Close the dev cli and then start it again
  4. Check if the local changes are synced

@adnanhashmi09 adnanhashmi09 changed the title run docker compose build before running docker compose watch to sync any local files changes run docker compose build before running docker compose watch to sync any local files changes between container restarts Jun 18, 2024
samad-yar-khan
samad-yar-khan approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@samad-yar-khan samad-yar-khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adnanhashmi09 adnanhashmi09 merged commit ced8717 into main Jun 18, 2024
@adnanhashmi09 adnanhashmi09 deleted the file-persistence branch June 18, 2024 08:51
@adnanhashmi09 adnanhashmi09 mentioned this pull request Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@samad-yar-khan samad-yar-khan samad-yar-khan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adnanhashmi09 @samad-yar-khan