test(core): add tests for getAddressType #183
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
annazhlb
changed the title
opcode0x
requested changes
Aug 21, 2025
| expect(getAddressType(p2trRegtest!)).toBe("p2tr"); | ||
| }); | ||
|
|
||
| it("returns P2PKH type", () => { |
There was a problem hiding this comment.
we won't support P2PKH addresses in the nearest future
| }); | ||
|
|
||
| it("returns P2TR type", () => { | ||
| const { address: p2trMainnet } = bitcoin.payments.p2tr({ |
There was a problem hiding this comment.
const p2wpkhMainnetAddress = bitcoin.payments.p2sh({
redeem: bitcoin.payments.p2wpkh({
pubkey: keyPairMainnet.publicKey,
network: mainnet,
}),
network: mainnet,
}).address as string;
let's do like this an we can opt out biome ingores
There was a problem hiding this comment.
biome ignores are no longer used.
an string type is now provided for the address when calling the function
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packages/core/src/utils/fixtures/getBitcoinAddress.ts