Changed compressionQuality by default to 0 #1744

vicajilau · 2025-03-27T16:31:19Z

navaronbracke

@vicajilau Does this fix the compression quality bug?

Maybe we should just have allowCompression be deprecated (and removed in the Java class).

I think we can look at the value of compressionQuality to determine if we should compress the image? Like, if compressionQuality is 0 (which would be the new default), we do not compress.

daniJimen · 2025-03-28T07:55:41Z

@vicajilau @navaronbracke many thanks for your fast resolution, i appreciate that, for me the resolution its perfect! i would add only one think about that and its instead create the compressed image into pictures folder (when the user set any compression level), create the image into app folder to not create a lot of images into a shared folder

vicajilau · 2025-03-28T08:22:27Z

@navaronbracke and @daniJimen, We have to keep in mind that only Android and iOS uses these two properties (allowCompression and compressionQuality). Compression capability is ignored on all other platforms (Linux, macOS, Windows and Web).

navaronbracke

Some small remarks, but otherwise LGTM.

Sadly changing the default compression quality could be seen as a breaking change? (Even though it is used to fix a bug)

navaronbracke · 2025-03-28T10:10:48Z

lib/src/file_picker_io.dart

      if (onFileLoading != null) {
        _eventSubscription = _eventChannel.receiveBroadcastStream().listen(
-              (data) => onFileLoading((data as bool)
+              (data) => onFileLoading((data is bool)


Nice catch!

its still broken

@aprzedecki : #1848

ios/file_picker/Sources/file_picker/ImageUtils.m

ios/file_picker/Sources/file_picker/FilePickerPlugin.m

navaronbracke · 2025-03-28T10:18:15Z

android/src/main/java/com/mr/flutter/plugin/filepicker/FileUtils.java

+        String timeStamp = new SimpleDateFormat("yyyyMMdd_HHmmss", Locale.getDefault()).format(new Date());
        String imageFileName = "JPEG_" + timeStamp + "_";
-        File storageDir = Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_PICTURES);
+        File storageDir = context.getCacheDir();


This change is to fix #1743 ?

YES!! And not only because this will fix #1742 too, also aligning android and iOS flows

navaronbracke · 2025-03-28T10:18:36Z

android/src/main/java/com/mr/flutter/plugin/filepicker/FileUtils.java

-    private static File createImageFile() throws IOException {
-        String timeStamp = new SimpleDateFormat("yyyyMMdd_HHmmss").format(new Date());
+    private static File createImageFile(Context context) throws IOException {
+        String timeStamp = new SimpleDateFormat("yyyyMMdd_HHmmss", Locale.getDefault()).format(new Date());


Good catch for the locale!

Co-authored-by: Navaron Bracke <[email protected]>

vicajilau · 2025-03-28T12:03:13Z

Everything ready @navaronbracke 🚀

…er-on-android

vicajilau · 2025-03-31T05:58:03Z

Conflicts resolved @navaronbracke

navaronbracke

We need to update the major version, since this changes the default value of the compressionQuality, so people might be surprised if the compression breaks when updating. (going from a default of 30 to 0)

CHANGELOG.md

pubspec.yaml

Co-authored-by: Navaron Bracke <[email protected]>

navaronbracke · 2025-03-31T06:44:23Z

CHANGELOG.md

@@ -1,10 +1,18 @@
+## 10.0.0
+### General
+- The `compressionQuality` property in the `pickFiles` method now defaults to `0`, and `allowCompression` is set to `false`. [@vicajilau](https://github.com/vicajilau).


I think you removed the wrong duplicated section here? Now the breaking change label is gone.

vicajilau · 2025-03-31T06:44:34Z

Everything ready as you suggested @navaronbracke 🚀

navaronbracke · 2025-03-31T06:45:15Z

Updated the OP so that the mentioned issues will be closed when this is merged.

Removed compressionQuality by default

98f8289

vicajilau linked an issue Mar 27, 2025 that may be closed by this pull request

Bug: Image duplication in "Pictures" folder on Android #1743

Closed

vicajilau requested a review from navaronbracke March 27, 2025 16:31

navaronbracke requested changes Mar 28, 2025

View reviewed changes

vicajilau changed the title ~~Removed compressionQuality by default~~ Changed compressionQuality by default to 0 Mar 28, 2025

vicajilau added 8 commits March 28, 2025 09:39

deprecated allowCompression

c08b19f

removed allowCompression

bf05dbf

allowCompression by default is false

1f790b5

Fixed linter issue

dc64845

Fixed comment message

2979ec0

Fixed more linter issues

d19c794

allowCompression is read by compressionQuality

ce250c2

saved on cache folder on Android

beaf798

navaronbracke requested changes Mar 28, 2025

View reviewed changes

vicajilau mentioned this pull request Mar 28, 2025

Android 11 or less - permission denied exception when compressionQuality not 0 #1742

Closed

1 task

vicajilau and others added 4 commits March 28, 2025 11:28

restored SimpleDateFormat

a76f735

Update ios/file_picker/Sources/file_picker/ImageUtils.m

9818bd2

Co-authored-by: Navaron Bracke <[email protected]>

Update ios/file_picker/Sources/file_picker/FilePickerPlugin.m

430defe

Co-authored-by: Navaron Bracke <[email protected]>

fixed import locale

f7202d5

vicajilau requested a review from navaronbracke March 28, 2025 10:37

https://github.com/miguelpruivo/flutter_file_picker/issues/1742

1a80fa5

Merge branch 'master' into feature/image-duplication-in-pictures-fold…

74b6c1d

…er-on-android

navaronbracke requested changes Mar 31, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

pubspec.yaml Outdated Show resolved Hide resolved

vicajilau and others added 3 commits March 31, 2025 08:39

Update CHANGELOG.md

6574b5c

Co-authored-by: Navaron Bracke <[email protected]>

Update pubspec.yaml

1916232

Co-authored-by: Navaron Bracke <[email protected]>

Fixed free space on CHANGELOG.md

2edad87

Fixed duplicated on CHANGELOG.md

c4d740b

vicajilau requested a review from navaronbracke March 31, 2025 06:43

navaronbracke reviewed Mar 31, 2025

View reviewed changes

Update CHANGELOG.md

ea67f59

navaronbracke approved these changes Mar 31, 2025

View reviewed changes

Fix typo

3f0c3e4

navaronbracke merged commit 2012577 into master Mar 31, 2025
3 checks passed

vicajilau deleted the feature/image-duplication-in-pictures-folder-on-android branch March 31, 2025 08:34

gnprice mentioned this pull request Apr 17, 2025

Upgrade Flutter, packages and Android build dependencies zulip/zulip-flutter#1474

Merged

Changed compressionQuality by default to 0 #1744

Changed compressionQuality by default to 0 #1744

Uh oh!

Conversation

vicajilau commented Mar 27, 2025 • edited by navaronbracke Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

navaronbracke left a comment

Choose a reason for hiding this comment

Uh oh!

daniJimen commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vicajilau commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

navaronbracke left a comment

Choose a reason for hiding this comment

Uh oh!

navaronbracke Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

aprzedecki Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

vicajilau Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

navaronbracke Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

vicajilau Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

navaronbracke Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

vicajilau commented Mar 28, 2025

Uh oh!

vicajilau commented Mar 31, 2025

Uh oh!

navaronbracke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

navaronbracke Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

vicajilau commented Mar 31, 2025

Uh oh!

navaronbracke commented Mar 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vicajilau commented Mar 27, 2025 •

edited by navaronbracke

Loading

daniJimen commented Mar 28, 2025 •

edited

Loading

vicajilau commented Mar 28, 2025 •

edited

Loading

vicajilau Mar 28, 2025 •

edited

Loading