Alter odd emphasis, fix some typos, add links #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, very nice! Thank you. 👍 Do you think you could keep |
The guide is currently mostly for React 0.12
|
Sure, done. |
mikechau
added a commit
that referenced
this pull request
Mar 24, 2015
Alter odd emphasis, fix some typos, add links
|
🙇 |
|
I'm reading over your changes again @xmo-odoo and I'm really impressed. Thank so much, would you be interested in being a reviewer? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have serious trouble reading the existing emphasis which uses
code spans(and there's a bit too much of it), this branch either removes emphasis or replaces the code spans with regular emphasis where the content is not code.Also:
Component#getDOMNode()calls byReact.findDOMNode(Component)(that might be a bit of an issue as, according to Using ES6 classes for more idiomatic React? #4, this is a React 0.12 guide and I assumed 0.13)