Code

Several Windows fixes.#23

Code

Merged

mikehaertl merged 6 commits intomikehaertl:mastermikehaertl/php-shellcommand:masterfrom

angrybrad:masterangrybrad/php-shellcommand:masterCopy head branch name to clipboard

Jun 30, 2017

Commits

Commits on Feb 9, 2017

• Only change to a drive letter first, if it is an absolute path on Windows.

  angrybrad

  committed
  3c9ba19

  Copy full SHA for 3c9ba19

• Fix a bug where quoted absolute paths on Windows wouldn't work. i.e. "C:\Program Files (x86)\file.exe" --foo=bar

  angrybrad

  committed
  aac2452

  Copy full SHA for aac2452

• Fix a bug where the right syntax wasn't being used to change drives on Windows.

  angrybrad

  committed
  1bc32b7

  Copy full SHA for 1bc32b7

Commits on Feb 10, 2017

• Use the correct syntax to make sure you're on the right drive letter on Windows.

  angrybrad

  committed
  ae92d1c

  Copy full SHA for ae92d1c

• Did not mean to remove escapeshellarg in ae92d1ceca2af4f7.

  angrybrad

  committed
  24ed4ed

  Copy full SHA for 24ed4ed

Commits on Jun 29, 2017

• Move $position into its own else block and default it to false instead of null.

  angrybrad

  authored
  c12ae7b

  Copy full SHA for c12ae7b