add tested workaround for retrying DNS lookups #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkeloscar
reviewed
Jun 15, 2018
main.go
Outdated
| select { | ||
| case <-time.After(30 * time.Second): | ||
| kubeConfig.Transport.CloseIdleConnections() | ||
| case <-stopChan: |
There was a problem hiding this comment.
This channel is being read from twice, here and in the controller. We need two different channels or something like this, for this to work.
There was a problem hiding this comment.
see https://play.golang.org/p/M1QJsNKw4Pu we use it in skipper to shutdown >1 goroutines, too
There was a problem hiding this comment.
Ah you are right, we close the channel, I was thinking that you can't read twice!
szuecs
force-pushed
the
fix/transport-miss-dns-retries
branch
from
42e6d0f to
2f0a4c1
Compare
|
@mikkeloscar based on your comment here code showing that the shutdown handling works https://play.golang.org/p/M1QJsNKw4Pu . We use it in skipper to shutdown all goroutines from one channel. |
|
👍 |
|
Unfortunately, client-go complains if you try to use a custom transport: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use workaround to handle golang/go#23427