Skip to content

Conversation

diplfranzhoepfinger
Copy link
Contributor

@RobTillaart
Copy link
Contributor

Interesting addition for a vertical market.
Does not interfere with anything of the code so no risks imho

@diplfranzhoepfinger
Can you add some comments in the file? meta info / header?

Thinking of this.

# Author: diplfranzhoepfinger 
# reference:  https://docs.espressif.com/projects/arduino-esp32/en/latest/esp-idf_component.html
# URL: https://github.com/milesburton/Arduino-Temperature-Control-Library
# DATE: 
...

@RobTillaart
Copy link
Contributor

LGTM

@milesburton
Copy link
Owner

LGTM

I had to google that Rob!

@milesburton milesburton merged commit e3c7276 into milesburton:master Feb 15, 2023
@diplfranzhoepfinger
Copy link
Contributor Author

I had to google that Rob!

who is Rob ?

@milesburton
Copy link
Owner

@diplfranzhoepfinger Ah sorry, I was referring to @RobTillaart and his use of 'LGTM' of which I've never seen before :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants