Skip to content

Forge only wants lowercased MODIDs, let's sanity check that! #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cpw
Copy link
Contributor

@cpw cpw commented May 30, 2017

In line with vanilla since 1.11, modids should only be lowercase. This PR attempts to (no doubt awfully) try and enforce that restriction for Forge mods.

@DenWav
Copy link
Member

DenWav commented May 30, 2017

In this case perhaps the creator should have separate fields for mod name and mod id, right? Since mod name wouldn't also have this restriction.

@cpw
Copy link
Contributor Author

cpw commented May 31, 2017

The mod's name isn't generally the modid no. The modid has some special rules. All lowercase is the biggest one. It gets transformed into a file path which means no colons. It also has a length restriction.

@stephan-gh
Copy link
Contributor

The same applies to Sponge so it would be good to have the separate fields for name + ID and the check there as well.

@DenWav
Copy link
Member

DenWav commented May 31, 2017

Do you want to try and fiddle with the UI to accomplish that @cpw? Feel free if you do. If not, it won't be difficult for me to implement this.

@cpw
Copy link
Contributor Author

cpw commented May 31, 2017

I think you know your way around the UI better than I do @DemonWav.

@DenWav
Copy link
Member

DenWav commented Jan 14, 2018

I've created issue #339 to address this, as I'll be making changes to the UI to fix this.

@DenWav DenWav closed this Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants