Fixing some issues with rollup #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrlee
commented
Mar 24, 2025
| @@ -32,7 +32,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@rollup/plugin-commonjs": "^28.0.2", | |||
| "@rollup/plugin-node-resolve": "^16.0.0", | |||
| "@rollup/plugin-node-resolve": "^16.0.1", | |||
There was a problem hiding this comment.
this wasn't being used which led to a warning about
(!) Unresolved dependencies
https://rollupjs.org/troubleshooting/#warning-treating-module-as-external-dependency
stream (imported by "dist/main/RestClient.d.ts")
andrewrlee
commented
Mar 24, 2025
| @@ -12,13 +13,13 @@ export default [ | |||
| { file: pkg.main, format: 'cjs', sourcemap: true }, | |||
| { file: pkg.module, format: 'esm', sourcemap: true }, | |||
| ], | |||
| plugins: [typescript({ tsconfig: './tsconfig.json' })], | |||
| plugins: [nodeResolve({ preferBuiltins: true }), typescript({ tsconfig: './tsconfig.json', noEmitOnError: true })], | |||
There was a problem hiding this comment.
Missing noEmitOnError led to rollup building even if there were type errors
andrewrlee
force-pushed
the
alee/fix-rollup-issues
branch
from
74f6654 to
8b72585
Compare
andrewrlee
commented
Mar 24, 2025
| @@ -6,7 +6,8 @@ | |||
| "outDir": "./dist", | |||
| "declarationDir": "./dist", | |||
| "resolveJsonModule": true, | |||
| "sourceMap": true | |||
There was a problem hiding this comment.
rollup was complaining about module needing to be set to Node16 :
(!) [plugin typescript] @rollup/plugin-typescript TS5110: Option 'module' must be set to 'Node16' when option 'moduleResolution' is set to 'Node16'.
This didn't make sense as we had a chain of extends going to @tsconfig/node22/tsconfig.json which sets it there.
This was preventing typechecking entirely
Looks like there's a bug where extending doesn't work for modules
andrewrlee
force-pushed
the
alee/fix-rollup-issues
branch
9 times, most recently
from
65cbb27 to
aeb9b15
Compare
andrewrlee
force-pushed
the
alee/fix-rollup-issues
branch
from
aeb9b15 to
5fafa0d
Compare
Thomas-Geraghty
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.