Skip to content

Wrap vref in opaque type to allow exhaustive matching on Value enum outside of crate #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Wrap vref in opaque type to allow exhaustive matching on Value enum outside of crate #503

wants to merge 1 commit into from

Conversation

cirla
Copy link

@cirla cirla commented Dec 10, 2024

Addresses #502 by creating a public type for the Value::Other variant with an opaque, private ValueRef inside

khvzak added a commit that referenced this pull request Dec 10, 2024
@khvzak
Allow exhaustive match on Value.
cd4091f 
It was not possible because `ValueRef` variant in `Value::Other` was private.
Closes #502 and #503
@khvzak
Copy link
Member

khvzak commented Dec 10, 2024

Thank for the PR
I would prefer at this point more easier solution to mark ValueRef as public (it still cannot be used or accessed anywhere).

@khvzak khvzak closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cirla @khvzak @tim-spectrust