Skip to content

Remove dead code about vm space in immortal space #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Aug 7, 2025

We once used ImmortalSpace for VM space. #864 introduced a separate policy for VMSpace, and these code in ImmortalSpace became dead code since then. This PR removes the dead code.

@qinsoon qinsoon requested a review from k-sareen August 7, 2025 04:37
Copy link
Collaborator

@k-sareen k-sareen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@qinsoon qinsoon enabled auto-merge August 7, 2025 04:46
@qinsoon qinsoon added this pull request to the merge queue Aug 7, 2025
Merged via the queue into mmtk:master with commit 83dc4c4 Aug 7, 2025
32 checks passed
@qinsoon qinsoon deleted the remove-vm-space-deadcode-in-immortal branch August 7, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants