Skip to content

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Sep 22, 2025

Minor fixes to the tracing scripts:

  • Remove vim modeline at the end of the bt file. Otherwise I got an error.
    ERROR: syntax error, unexpected end predicate, expecting {
    // vim: ft=bpftrace ts=4 sw=4 sts=4 et
    ~
    
  • Move concurrent_pause_determined in enrich_metadata from wp to gc. It should add args for GCs, not work packets.

@qinsoon qinsoon requested a review from wks September 22, 2025 01:06
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon added this pull request to the merge queue Oct 1, 2025
Merged via the queue into mmtk:master with commit a9074a3 Oct 1, 2025
32 checks passed
@qinsoon qinsoon deleted the tools-tracing-timeline-minor-fix branch October 1, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants