Skip to content

Refactor Metadata #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jun 25, 2021
Merged

Refactor Metadata #342

merged 29 commits into from
Jun 25, 2021

Conversation

javadamiri
Copy link
Contributor

@javadamiri javadamiri commented Jun 8, 2021

This PR refactors metadata so that it becomes more general and some of its use-cases such as gc_byte and header_byte become consistent with other uses of metadata, and closes issue #320.

A summary of changes:

1 - Make side_metadata a sub-module of the metadata module and generalise the SideMetadataSpec to MetadataSpec with an additional field to indicate whether the spec is on-side or in-header.
2 - Add optional atomic ordering to metadata operations.
3 - Move the definition of per-object Metadata specifications to the VM object model.
4 - Remove gc_byte and header_byte modules.

The new metadata design differentiates per-object metadata (e.g. forwarding-bits and marking-bit) from other types of metadata including per-address (e.g. alloc-bit) and per-X (where X != object size), because the per-object metadata can optionally be kept in the object headers.

MMTk now acknowledges the VM-dependant nature of the in-object metadata, and asks the VM bindings to contribute by implementing the related parts in the ObjectModel.

@javadamiri
Copy link
Contributor Author

openjdk-binding-test
OPENJDK_BINDING_REF=metadata_refactoring

@javadamiri
Copy link
Contributor Author

jikesrvm-binding-test
JIKESRVM_BINDING_REF=metadata_refactoring

@javadamiri
Copy link
Contributor Author

jikesrvm-perf-compare
JIKESRVM_BINDING_BRANCH_REF=metadata_refactoring

@javadamiri
Copy link
Contributor Author

openjdk-perf-compare
OPENJDK_BINDING_BRANCH_REF=metadata_refactoring

@javadamiri javadamiri added the PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) label Jun 11, 2021
@javadamiri
Copy link
Contributor Author

v8-binding-test
V8_BINDING_REF=metadata_refactoring

@javadamiri javadamiri removed the PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) label Jun 11, 2021
@javadamiri javadamiri added PR-benchmarking PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) labels Jun 11, 2021
@javadamiri javadamiri removed PR-benchmarking PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) labels Jun 15, 2021
@javadamiri javadamiri marked this pull request as ready for review June 15, 2021 10:02
@javadamiri javadamiri linked an issue Jun 16, 2021 that may be closed by this pull request
@javadamiri javadamiri added PR-benchmarking PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) and removed PR-benchmarking labels Jun 23, 2021
@github-actions
Copy link

OpenJDK Micro Benchmarks

Running: ['rebench', 'microbm.conf', 'CI_SemiSpace']

Benchmark Trunk (ms) Branch (ms) Diff
BinaryTrees 1909.05 1912.86 +0.20%
Fasta 933.08 938.22 +0.55%
GCBenchMT 1435.04 1436.02 +0.07%
GCBenchST 107.91 108.29 +0.35%
ReverseComplement 52.57 52.59 +0.05%

@github-actions
Copy link

OpenJDK

SemiSpace (wrench-2021-06-23-Wed-154208)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 438.82 ±13.69 ⚠️ 2/40 failed 438.82 ±13.69 451.0 428.25 ±13.99 ⚠️ 4/40 failed 428.25 ±13.99 417.5 -2.41% -2.41% 🟩
eclipse 7475.60 ±11.00 7472.77 ±9.64 ⚠️ 1 removed 7484.0 7456.98 ±42.69 7438.64 ±21.71 ⚠️ 1 removed 7476.5 -0.25% -0.46%
fop 478.20 ±0.86 478.20 ±0.86 478.0 476.35 ±0.92 476.08 ±0.76 ⚠️ 1 removed 476.0 -0.39% -0.44%
hsqldb 434.57 ±1.00 434.57 ±1.00 435.0 434.05 ±1.58 434.05 ±1.58 434.0 -0.12% -0.12%
pmd 1227.33 ±4.13 1227.33 ±4.13 1225.0 1227.88 ±5.45 1224.89 ±3.63 ⚠️ 2 removed 1225.5 +0.04% -0.20%

GenCopy (wrench-2021-06-23-Wed-175016)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 401.80 ±1.67 401.80 ±1.67 402.5 402.76 ±0.84 ⚠️ 2/40 failed 402.31 ±0.57 ⚠️ 2 removed 402.0 +0.24% +0.13%
eclipse 7922.73 ±16.12 7922.73 ±16.12 7925.5 7945.00 ±20.51 7939.21 ±17.28 ⚠️ 1 removed 7935.5 +0.28% +0.21%
fop 484.65 ±1.06 484.36 ±0.91 ⚠️ 1 removed 484.0 484.25 ±1.32 483.74 ±0.86 ⚠️ 1 removed 484.0 -0.08% -0.13%
hsqldb 369.82 ±2.82 369.82 ±2.82 370.0 370.25 ±2.20 370.25 ±2.20 369.5 +0.11% +0.11%
pmd 1467.35 ±16.97 1467.35 ±16.97 1455.0 1451.03 ±16.18 1451.03 ±16.18 1440.5 -1.11% -1.11% 🟩

@github-actions
Copy link

JikesRVM

NoGC (wrench-2021-06-23-Wed-202614)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 785.17 ±3.44 785.17 ±3.44 786.0 784.67 ±3.50 784.67 ±3.50 784.0 -0.06% -0.06%
fop 630.08 ±1.47 630.08 ±1.47 630.0 631.50 ±2.04 630.90 ±1.68 ⚠️ 1 removed 630.5 +0.23% +0.13%
luindex 2278.60 ±7.32 2278.60 ±7.32 2277.0 2278.12 ±6.98 2276.18 ±5.92 ⚠️ 1 removed 2280.5 -0.02% -0.11%

SemiSpace (wrench-2021-06-23-Wed-203814)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 614.80 ±3.99 614.80 ±3.99 612.0 618.88 ±3.10 618.88 ±3.10 618.0 +0.66% +0.66%
bloat 2277.35 ±25.22 2277.35 ±25.22 2273.0 2273.97 ±26.07 2273.97 ±26.07 2274.5 -0.15% -0.15%
fop 594.38 ±1.20 594.38 ±1.20 595.0 593.35 ±1.28 593.35 ±1.28 593.5 -0.17% -0.17%
hsqldb 646.92 ±8.40 646.92 ±8.40 651.0 651.45 ±6.06 651.45 ±6.06 651.5 +0.70% +0.70%
jython 1692.90 ±7.87 1692.90 ±7.87 1692.5 1698.30 ±6.55 1698.30 ±6.55 1698.0 +0.32% +0.32%
luindex 2304.28 ±8.63 2304.28 ±8.63 2310.0 2314.55 ±8.18 2312.46 ±7.20 ⚠️ 1 removed 2313.0 +0.45% +0.36%
lusearch 649.65 ±14.50 645.87 ±12.65 ⚠️ 1 removed 640.5 618.20 ±19.48 613.05 ±16.91 ⚠️ 1 removed 608.5 -4.84% -5.08% 🟩
pmd 1258.53 ±6.79 1258.53 ±6.79 1255.5 1262.72 ±8.75 1262.72 ±8.75 1265.5 +0.33% +0.33%
xalan 508.90 ±3.90 508.90 ±3.90 509.5 515.10 ±3.25 515.10 ±3.25 516.0 +1.22% +1.22% 🟥

@github-actions
Copy link

OpenJDK

SemiSpace (wrench-2021-06-23-Wed-220841)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 437.19 ±13.39 ⚠️ 4/40 failed 437.19 ±13.39 443.5 427.22 ±14.41 ⚠️ 8/40 failed 427.22 ±14.41 432.5 -2.28% -2.28% 🟩
eclipse 7487.45 ±20.10 7481.26 ±16.14 ⚠️ 1 removed 7484.0 7430.25 ±15.99 7430.25 ±15.99 7431.0 -0.76% -0.68%
fop 477.35 ±0.91 477.13 ±0.81 ⚠️ 1 removed 477.5 475.73 ±0.84 475.73 ±0.84 476.0 -0.34% -0.29%
hsqldb 434.27 ±1.59 434.27 ±1.59 434.5 434.75 ±2.05 434.03 ±1.47 ⚠️ 1 removed 434.0 +0.11% -0.06%
pmd 1223.85 ±3.86 1223.85 ±3.86 1222.5 1228.97 ±4.55 1228.97 ±4.55 1228.5 +0.42% +0.42%

GenCopy (wrench-2021-06-24-Thu-001645)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 401.30 ±1.69 401.30 ±1.69 402.0 402.48 ±0.57 402.48 ±0.57 402.0 +0.29% +0.29%
eclipse 7979.80 ±63.27 7954.87 ±39.24 ⚠️ 1 removed 7926.0 7915.12 ±16.48 7911.21 ±14.84 ⚠️ 1 removed 7919.5 -0.81% -0.55%
fop 484.00 ±0.84 484.00 ±0.84 484.0 484.10 ±0.80 484.10 ±0.80 484.0 +0.02% +0.02%
hsqldb 367.93 ±2.66 367.93 ±2.66 370.0 368.90 ±3.07 368.08 ±2.65 ⚠️ 1 removed 370.0 +0.26% +0.04%
pmd 1459.92 ±16.85 1459.92 ±16.85 1448.0 1456.62 ±13.33 1456.62 ±13.33 1449.5 -0.23% -0.23%

@javadamiri javadamiri added PR-benchmarking and removed PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) PR-benchmarking labels Jun 24, 2021
@github-actions
Copy link

OpenJDK Micro Benchmarks

Running: ['rebench', 'microbm.conf', 'CI_SemiSpace']

Benchmark Trunk (ms) Branch (ms) Diff
BinaryTrees 1914.21 1911.54 -0.14%
Fasta 935.32 937.42 +0.23%
GCBenchMT 1435.67 1436.70 +0.07%
GCBenchST 107.82 107.67 -0.14%
ReverseComplement 52.09 52.11 +0.03%

@github-actions
Copy link

JikesRVM

NoGC (wrench-2021-06-25-Fri-113637)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 776.88 ±3.46 776.88 ±3.46 776.5 784.02 ±4.28 782.85 ±3.65 ⚠️ 1 removed 783.5 +0.92% +0.77%
fop 631.50 ±1.54 631.50 ±1.54 632.0 629.88 ±1.46 629.88 ±1.46 629.0 -0.26% -0.26%
luindex 2273.43 ±7.46 2273.43 ±7.46 2272.5 2273.00 ±7.14 2273.00 ±7.14 2273.0 -0.02% -0.02%

SemiSpace (wrench-2021-06-25-Fri-114837)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 617.60 ±5.06 615.77 ±3.54 ⚠️ 1 removed 614.5 621.23 ±3.85 621.23 ±3.85 619.0 +0.59% +0.89%
bloat 2305.15 ±32.68 2296.90 ±28.85 ⚠️ 1 removed 2293.0 2280.03 ±27.85 2271.33 ±22.18 ⚠️ 1 removed 2295.5 -1.09% -1.11% 🟩
fop 594.42 ±1.25 594.42 ±1.25 594.0 594.12 ±1.42 594.12 ±1.42 594.0 -0.05% -0.05%
hsqldb 647.90 ±8.88 647.90 ±8.88 650.0 648.90 ±5.91 648.90 ±5.91 647.5 +0.15% +0.15%
jython 1699.05 ±8.30 1699.05 ±8.30 1694.5 1696.33 ±9.46 1696.33 ±9.46 1693.0 -0.16% -0.16%
luindex 2305.93 ±6.65 2305.93 ±6.65 2305.0 2303.72 ±6.84 2303.72 ±6.84 2300.0 -0.10% -0.10%
lusearch 601.55 ±13.38 601.55 ±13.38 605.0 666.73 ±15.61 666.73 ±15.61 663.0 +10.83% +10.83% 🟥
pmd 1266.78 ±6.98 1265.10 ±6.27 ⚠️ 1 removed 1265.0 1261.03 ±6.99 1261.03 ±6.99 1264.0 -0.45% -0.32%
xalan 517.15 ±3.32 517.15 ±3.32 519.5 514.92 ±3.47 514.92 ±3.47 515.0 -0.43% -0.43%

@github-actions
Copy link

OpenJDK

SemiSpace (spanner-2021-06-25-Fri-095849)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 422.89 ±0.59 ⚠️ 4/40 failed 422.89 ±0.59 423.0 423.29 ±0.84 ⚠️ 5/40 failed 423.29 ±0.84 423.0 +0.09% +0.09%
eclipse 7929.65 ±35.63 7929.65 ±35.63 7901.5 7954.50 ±45.18 7942.59 ±39.24 ⚠️ 1 removed 7901.0 +0.31% +0.16%
fop 503.15 ±1.33 502.62 ±0.80 ⚠️ 1 removed 502.0 506.85 ±0.70 506.85 ±0.70 506.5 +0.74% +0.84%
hsqldb 498.57 ±14.25 498.57 ±14.25 477.0 497.30 ±13.51 497.30 ±13.51 482.0 -0.26% -0.26%
pmd 1402.62 ±7.49 1402.62 ±7.49 1404.5 1401.12 ±10.17 1401.12 ±10.17 1395.0 -0.11% -0.11%

GenCopy (spanner-2021-06-25-Fri-121303)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 442.80 ±0.69 442.80 ±0.69 443.0 442.65 ±0.54 442.65 ±0.54 443.0 -0.03% -0.03%
eclipse 8681.33 ±45.92 8663.62 ±29.50 ⚠️ 1 removed 8685.0 8656.75 ±31.45 8656.75 ±31.45 8686.0 -0.28% -0.08%
fop 509.25 ±0.99 508.95 ±0.80 ⚠️ 1 removed 509.0 514.83 ±1.34 514.41 ±1.08 ⚠️ 1 removed 514.5 +1.09% +1.07% 🟥
hsqldb 410.40 ±5.80 408.21 ±3.83 ⚠️ 1 removed 410.5 405.82 ±3.60 405.82 ±3.60 408.5 -1.11% -0.58%
pmd 1664.35 ±18.40 1664.35 ±18.40 1645.0 1650.45 ±20.55 1650.45 ±20.55 1634.0 -0.84% -0.84%

@github-actions
Copy link

OpenJDK Micro Benchmarks

Running: ['rebench', 'microbm.conf', 'CI_SemiSpace']

Benchmark Trunk (ms) Branch (ms) Diff
BinaryTrees 1912.96 1910.74 -0.12%
Fasta 933.15 935.48 +0.25%
GCBenchMT 1436.24 1435.47 -0.05%
GCBenchST 107.72 107.80 +0.08%
ReverseComplement 52.16 52.02 -0.27%

@github-actions
Copy link

JikesRVM

NoGC (spanner-2021-06-25-Fri-174231)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 826.10 ±6.45 823.77 ±4.51 ⚠️ 1 removed 824.0 834.75 ±4.61 833.08 ±3.21 ⚠️ 1 removed 834.5 +1.05% +1.13% 🟥
fop 665.73 ±1.96 665.73 ±1.96 665.0 664.90 ±1.60 664.51 ±1.43 ⚠️ 1 removed 664.5 -0.12% -0.18%
luindex 2395.90 ±8.21 2395.90 ±8.21 2395.0 2405.50 ±6.55 2405.50 ±6.55 2411.5 +0.40% +0.40%

SemiSpace (spanner-2021-06-25-Fri-175511)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 669.08 ±5.35 669.08 ±5.35 666.0 666.80 ±4.32 666.80 ±4.32 666.5 -0.34% -0.34%
bloat 2424.82 ±24.84 2424.82 ±24.84 2414.0 2487.38 ±31.68 2479.23 ±27.79 ⚠️ 1 removed 2490.0 +2.58% +2.24% 🟥
fop 626.58 ±1.04 626.58 ±1.04 627.0 626.52 ±1.61 626.52 ±1.61 626.5 -0.01% -0.01%
hsqldb 697.15 ±3.48 697.15 ±3.48 696.0 697.05 ±4.04 695.82 ±3.27 ⚠️ 1 removed 695.5 -0.01% -0.19%
jython 1835.60 ±8.58 1835.60 ±8.58 1838.5 1828.45 ±7.58 1828.45 ±7.58 1826.5 -0.39% -0.39%
luindex 2460.75 ±12.57 2460.75 ±12.57 2462.5 2460.40 ±10.51 2460.40 ±10.51 2459.0 -0.01% -0.01%
lusearch 819.45 ±11.61 819.45 ±11.61 817.0 840.67 ±12.46 840.67 ±12.46 840.0 +2.59% +2.59% 🟥
pmd 1415.22 ±10.85 1415.22 ±10.85 1419.5 1429.83 ±11.80 1429.83 ±11.80 1435.0 +1.03% +1.03% 🟥
xalan 613.95 ±4.51 613.95 ±4.51 619.0 616.88 ±3.86 616.88 ±3.86 619.5 +0.48% +0.48%

@github-actions
Copy link

OpenJDK

SemiSpace (wrench-2021-06-25-Fri-191602)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 426.67 ±13.73 ⚠️ 1/40 failed 426.67 ±13.73 395.0 421.67 ±14.95 ⚠️ 1/40 failed 421.67 ±14.95 390.0 -1.17% -1.17% 🟩
eclipse 7491.75 ±50.62 7457.82 ±16.83 ⚠️ 2 removed 7478.5 7417.75 ±17.96 7417.75 ±17.96 7403.0 -0.99% -0.54%
fop 476.07 ±0.66 476.07 ±0.66 476.0 476.00 ±0.82 476.00 ±0.82 476.0 -0.02% -0.02%
hsqldb 435.23 ±1.11 435.23 ±1.11 435.0 433.73 ±1.70 433.26 ±1.45 ⚠️ 1 removed 434.0 -0.34% -0.45%
pmd 1223.85 ±4.05 1222.82 ±3.57 ⚠️ 1 removed 1223.5 1224.15 ±3.07 1224.15 ±3.07 1223.5 +0.02% +0.11%

GenCopy (wrench-2021-06-25-Fri-212400)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 409.70 ±7.40 405.18 ±3.94 ⚠️ 2 removed 403.0 406.28 ±5.62 ⚠️ 1/40 failed 402.41 ±0.52 ⚠️ 2 removed 402.0 -0.83% -0.69%
eclipse 7929.90 ±14.45 7929.90 ±14.45 7929.0 7933.90 ±36.73 7917.92 ±17.92 ⚠️ 1 removed 7917.5 +0.05% -0.15%
fop 483.90 ±0.89 483.90 ±0.89 484.0 484.57 ±0.86 484.57 ±0.86 485.0 +0.14% +0.14%
hsqldb 369.62 ±2.71 369.62 ±2.71 371.0 368.20 ±2.74 367.38 ±2.24 ⚠️ 1 removed 368.5 -0.39% -0.61%
pmd 1459.88 ±14.67 1459.88 ±14.67 1452.5 1462.10 ±16.95 1462.10 ±16.95 1452.0 +0.15% +0.15%

@github-actions
Copy link

JikesRVM

NoGC (wrench-2021-06-25-Fri-233743)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 782.62 ±6.61 780.00 ±4.05 ⚠️ 1 removed 777.5 786.70 ±3.87 786.70 ±3.87 788.0 +0.52% +0.86%
fop 633.30 ±1.53 633.30 ±1.53 633.0 630.65 ±1.85 630.65 ±1.85 629.0 -0.42% -0.42%
luindex 2265.43 ±5.50 2265.43 ±5.50 2266.5 2273.45 ±5.82 2273.45 ±5.82 2274.0 +0.35% +0.35%

SemiSpace (wrench-2021-06-25-Fri-234942)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 651.70 ±11.80 651.70 ±11.80 648.5 646.33 ±11.12 646.33 ±11.12 642.0 -0.82% -0.82%
bloat 2309.05 ±26.15 2309.05 ±26.15 2308.5 2264.80 ±23.48 2264.80 ±23.48 2255.0 -1.92% -1.92% 🟩
fop 593.75 ±1.21 593.75 ±1.21 593.5 593.00 ±1.32 593.00 ±1.32 593.0 -0.13% -0.13%
hsqldb 637.55 ±10.86 637.55 ±10.86 646.0 648.42 ±7.14 648.42 ±7.14 649.0 +1.71% +1.71% 🟥
jython 1701.30 ±9.09 1701.30 ±9.09 1699.5 1692.20 ±7.45 1692.20 ±7.45 1689.0 -0.53% -0.53%
luindex 2311.18 ±8.31 2311.18 ±8.31 2311.0 2306.28 ±7.31 2306.28 ±7.31 2304.5 -0.21% -0.21%
lusearch 585.62 ±15.85 585.62 ±15.85 582.0 662.05 ±14.31 657.72 ±11.62 ⚠️ 1 removed 661.0 +13.05% +12.31% 🟥
pmd 1257.15 ±7.37 1257.15 ±7.37 1257.0 1260.38 ±6.09 1260.38 ±6.09 1264.0 +0.26% +0.26%
xalan 517.83 ±3.73 516.92 ±3.34 ⚠️ 1 removed 517.0 518.42 ±3.64 518.42 ±3.64 519.5 +0.12% +0.29%

@github-actions
Copy link

OpenJDK Micro Benchmarks

Running: ['rebench', 'microbm.conf', 'CI_SemiSpace']

Benchmark Trunk (ms) Branch (ms) Diff
BinaryTrees 1912.13 1912.73 +0.03%
Fasta 934.52 934.87 +0.04%
GCBenchMT 1435.49 1436.67 +0.08%
GCBenchST 107.73 108.05 +0.30%
ReverseComplement 52.32 52.13 -0.36%

@github-actions
Copy link

OpenJDK

SemiSpace (spanner-2021-06-25-Fri-222420)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 422.92 ±1.49 ⚠️ 2/40 failed 422.92 ±1.49 423.0 422.45 ±0.69 ⚠️ 2/40 failed 422.27 ±0.61 ⚠️ 1 removed 422.0 -0.11% -0.15%
eclipse 8016.90 ±46.36 8016.90 ±46.36 7979.5 7972.48 ±42.32 7972.48 ±42.32 7909.0 -0.55% -0.55%
fop 503.25 ±0.83 503.00 ±0.68 ⚠️ 1 removed 503.0 503.68 ±0.81 503.68 ±0.81 504.0 +0.08% +0.13%
hsqldb 505.23 ±14.96 505.23 ±14.96 484.5 495.73 ±12.89 495.73 ±12.89 480.0 -1.88% -1.88% 🟩
pmd 1406.33 ±9.48 1406.33 ±9.48 1401.5 1410.05 ±9.44 1410.05 ±9.44 1413.0 +0.26% +0.26%

GenCopy (spanner-2021-06-26-Sat-003904)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 451.84 ±9.46 ⚠️ 2/40 failed 448.78 ±7.35 ⚠️ 1 removed 443.0 448.92 ±6.77 ⚠️ 2/40 failed 444.81 ±3.66 ⚠️ 2 removed 443.0 -0.65% -0.89%
eclipse 8701.90 ±40.40 8686.62 ±26.70 ⚠️ 1 removed 8698.5 8670.35 ±29.84 8670.35 ±29.84 8685.0 -0.36% -0.19%
fop 509.02 ±1.06 509.02 ±1.06 509.0 510.15 ±1.29 510.15 ±1.29 509.5 +0.22% +0.22%
hsqldb 409.45 ±5.84 407.18 ±3.70 ⚠️ 1 removed 408.0 408.80 ±2.78 408.80 ±2.78 410.5 -0.16% +0.40%
pmd 1680.47 ±23.30 1680.47 ±23.30 1660.5 1678.97 ±23.32 1678.97 ±23.32 1660.0 -0.09% -0.09%

@javadamiri javadamiri merged commit a288b40 into master Jun 25, 2021
@javadamiri javadamiri deleted the metadata_refactoring branch June 25, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup side_gc_byte
2 participants