Skip to content

Only skip problematic tests for max moving build #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: mmtk-support-moving-upstream
Choose a base branch
from
Open

Only skip problematic tests for max moving build #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/scripts/ci-test-other.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ REGEX_PATTERN='.*const TESTNAMES = \[([^\[]*)^\].*'
is_moving=$2
moving_feature=${is_moving,,}

declare -a tests_to_skip=(
declare -a max_moving_tests_to_skip=(
# see https://github.com/mmtk/mmtk-julia/issues/259
"abstractarray"
"cmdlineargs"
Expand Down Expand Up @@ -50,9 +50,11 @@ if [[ $CHOOSE_TESTS_JL_CONTENT =~ $REGEX_PATTERN ]]; then
continue
fi

if [[ "${tests_to_skip[@]}" =~ "$test" ]]; then
echo "-> Skip"
continue
if [[ "${max_moving_tests_to_skip[@]}" =~ "$test" ]]; then
if [ "$moving_feature" == "max_moving" ]; then
echo "-> Skip"
continue
fi
fi

if [[ $test =~ "compiler_extras" ]]; then
Expand Down
20 changes: 19 additions & 1 deletion .github/scripts/ci-test-stdlib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,21 @@ declare -a tests_to_skip=(
# see https://github.com/mmtk/mmtk-julia/issues/259
"Downloads"
"REPL"
"TOML"
"Random"
"LibCURL"
"LazyArtifacts"
)

declare -a max_moving_tests_to_skip=(
# Skipping tests that fail for max moving Immix
# see https://github.com/mmtk/mmtk-julia/issues/259
"Downloads"
"REPL"
"Random"
"LibCURL"
"LazyArtifacts"
)

# These tests need multiple workers.
declare -a tests_with_multi_workers=(
"Pkg"
Expand Down Expand Up @@ -78,6 +88,14 @@ do
continue
fi

# Skip tests with max moving build
if [[ "${max_moving_tests_to_skip[@]}" =~ "$test" ]]; then
if [ "$moving_feature" == "max_moving" ]; then
echo "-> Skip"
continue
fi
fi

if [[ "${tests_with_multi_workers[@]}" =~ "$test" ]]; then
echo "-> Run multi threaded"
ci_run_jl_test $test 2 $moving_feature
Expand Down