Skip to content

Use Julia's finalizer implementation #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 25, 2023
Merged

Use Julia's finalizer implementation #78

merged 8 commits into from
Jul 25, 2023

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Jul 13, 2023 •
edited
Loading

This PR updates to mmtk/julia#22.

  • Remove code about registering and running finalizers (we use whatever Julia does).
  • Add code for finalizer scanning in Rust.

@qinsoon qinsoon force-pushed the use-julia-finalizer-impl branch from c6a3fc6 to 822ccb5 Compare July 24, 2023 01:45
@qinsoon qinsoon marked this pull request as ready for review July 24, 2023 01:47
@qinsoon qinsoon requested a review from udesou July 24, 2023 01:47
udesou
udesou approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@udesou udesou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and much cleaner with reusing their code. Hopefully future changes they make with their finaliser code don't affect whatever we have on the MMTk side.

@qinsoon qinsoon merged commit 2b153c6 into mmtk:master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udesou udesou udesou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qinsoon @udesou