Skip to content

fix for stack overflow on osx #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 5, 2025
Merged

fix for stack overflow on osx #87

merged 4 commits into from
Jun 5, 2025

Conversation

mmwillet
Copy link
Owner

@mmwillet mmwillet commented Jun 4, 2025

Addresses stack overflow identified in #76

@mmwillet mmwillet mentioned this pull request Jun 4, 2025
Open
mmwillet
mmwillet commented Jun 4, 2025
View reviewed changes
mmwillet
mmwillet commented Jun 4, 2025
View reviewed changes
danielzgtg
danielzgtg approved these changes Jun 5, 2025
View reviewed changes
Copy link
Collaborator

@danielzgtg danielzgtg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good hotfix

In the long run, should we just call ggml_build_forward_expand more frequently to reduce the max stack required?

@mmwillet mmwillet merged commit 4ab66f9 into main Jun 5, 2025
2 checks passed
@mmwillet mmwillet deleted the fix-osx-stack-overflow branch June 5, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielzgtg danielzgtg danielzgtg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmwillet @danielzgtg