I'd like to contribute to mobx.dart with file generator

[copydog]

Now, I am writing annotation generator for mobx.dart.
Here is the repo, https://github.com/copydog/mobx_annotation

If you are interested, let me know how I can contribute to the mobx.dart.

[pavanpodila]

This is awesome 💯. I suggest you join our team as a collaborator and work on this monorepo. Once you become a collaborator, you can create a branch under this repo and add the annotation project at the root level, just like mobx or flutter_mobx.

Let me know if that's ok with you and I'll add you 😃

[copydog]

yes, it is ok with me, please add me to collaborator

[pavanpodila]

Just sent you the invite! Once you accept, you should be able to create a branch and send a PR with the annotations project added as a peer-folder of mobx. Look forward to seeing it!

I am sure it will drastically improve the the developer experience of using mobx.dart 👍

[copydog]

Should I use the name 'mobx_annotation' or any other name for this project?

[pavanpodila]

How about just "annotations"?

[rrousselGit]

Code-generators should be published as two separate packages anyway (see https://github.com/google/built_value.dart, https://github.com/dart-lang/json_serializable)

As such we'll likely need two separate names.

[katis]

I'd like the annotations to just live in the mobx package, that way you just need mobx and mobx_annotations (or the previously discussed mobx_codegen if annotations are in mobx) in your pubspec. I made my own codegen experiments in #46, and you can see the project structure there.

[pavanpodila]

The base annotations should be for observable, computed, action, which can live in the mobx package itself (as @katis suggested). From an end-user's perspective, it should come with batteries-included.

Similarly, we would also need the observer annotation for flutter_mobx. That could live in the flutter_mobx package

[copydog]

Just like mobx.js includes observable, computed, action in the main package, I think these annotations should be included in the mobx package (as @katis @pavanpodila suggested). Also, observer annotation should be in flutter_mobx package.

Btw, I like Observer personally, because I want fully control to widgets that need rebuild. I think 'observer' annotation might not be useful for other user too.

Last thing, I vote the name 'mobx_annotations' (as @katis suggested), just like other mobx.js package mobx-persist, mobx-devtools, etc.

[copydog]

Oh, this auto reference is so weird

[katis]

I just want to reiterate that I think having a package called mobx_annotations is a bit weird if it contains no annotations. Names like mobx_codegen, mobx_generator or mobx_store_generator at least hint that the package is a code generator, and as such should probably be in dev_dependencies: instead of dependencies

[pavanpodila]

I like the mobx_codegen name, as its very explicit about the intent. Are we still keeping a separate package for mobx_codegen or making it part of mobx. I need to read up on source_gen as I can feel some ignorance even asking this question 😉

[katis]

@pavanpodila the package needs to be separate, as it should just be a development time dependency.