fix: omit empty list of platforms when serializing worker config #5968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
approved these changes
May 13, 2025
Previously, when no platforms were explicitly defined in the config, serialization would emit an empty array instead of omitting the field. When loading this cofig, this prevented the worker from falling back to default platform detection during initialization. By using `omitempty`, we ensure the field is excluded when empty, allowing defaults to be correctly applied. Fixes moby#5740. Signed-off-by: Alberto Garcia Hierro <[email protected]>
fiam
force-pushed
the
alberto/omitempty-platforms-list
branch
from
b2dc826 to
50247f3
Compare
|
So before this change: Image that did not explicitly have a platform set, got an empty array for platforms? After this change: Images get the same platform as the builder node? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when no platforms were explicitly defined in the config,
serialization would emit an empty array instead of omitting the field.
When loading this cofig, this prevented the worker from falling back
to default platform detection during initialization. By using
omitempty,we ensure the field is excluded when empty, allowing defaults to be
correctly applied.
Fixes #5740.
Signed-off-by: Alberto Garcia Hierro [email protected]