Skip to content

Bump vendoring to match current docker/docker master #2886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

dperny
Copy link
Collaborator

@dperny dperny commented Aug 29, 2019

Updates vendor.conf so that the versions used all match the corresponding versions in github.com/docker/docker.

Updates vendor.conf so that the versions used all match the
corresponding versions in github.com/docker/docker.

Bumping the vendored version of gogo/protobuf required a few changes to
the swarmkit code for generating protos.

Signed-off-by: Drew Erny <[email protected]>
@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #2886 into master will decrease coverage by 0.49%.
The diff coverage is 21.93%.

@@            Coverage Diff            @@
##           master    #2886     +/-   ##
=========================================
- Coverage   62.07%   61.58%   -0.5%     
=========================================
  Files         139      139             
  Lines       22345    22616    +271     
=========================================
+ Hits        13870    13927     +57     
- Misses       6989     7216    +227     
+ Partials     1486     1473     -13

@dperny dperny merged commit e0f62d1 into moby:master Sep 5, 2019
thaJeztah added a commit to thaJeztah/docker that referenced this pull request Oct 7, 2019
full diff: moby/swarmkit@7dded76...a8bbe7d

changes included:

- moby/swarmkit#2867 Only update non-terminal tasks on node removal
  - related to moby/swarmkit#2806 Fix leaking task resources when nodes are deleted
- moby/swarmkit#2880 Bump to golang 1.12.9
- moby/swarmkit#2886 Bump vendoring to match current docker/docker master
  - regenerates protobufs
- moby/swarmkit#2890 Remove hardcoded IPAM config subnet value for ingress network
  - fixes [ENGORC-2651] Specifying --default-addr-pool for docker swarm init is not picked up by ingress network

Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah added a commit to thaJeztah/docker that referenced this pull request Oct 21, 2019
full diff: moby/swarmkit@7dded76...a8bbe7d

changes included:

- moby/swarmkit#2867 Only update non-terminal tasks on node removal
  - related to moby/swarmkit#2806 Fix leaking task resources when nodes are deleted
- moby/swarmkit#2880 Bump to golang 1.12.9
- moby/swarmkit#2886 Bump vendoring to match current docker/docker master
  - regenerates protobufs
- moby/swarmkit#2890 Remove hardcoded IPAM config subnet value for ingress network
  - fixes [ENGORC-2651] Specifying --default-addr-pool for docker swarm init is not picked up by ingress network

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant