Skip to content

Conversation

zhassan-aws
Copy link
Contributor

Add Lean action in CI to make sure the package doesn't break.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@zhassan-aws zhassan-aws requested review from BrunoDutertre and a team as code owners August 27, 2024 19:06
@zhassan-aws
Copy link
Contributor Author

@tautschnig
Copy link
Member

Does the action have some issues? It seems it is trying to save the cache twice (and the second one fails).

Copy link
Member

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving modulo the concerns with the action itself.

@zhassan-aws
Copy link
Contributor Author

Good catch. I'm seeing this error in other repos that use the action though, e.g:

https://github.com/leanprover-community/aesop/actions/runs/10507096078/job/29108109514#step:5:4

Not sure what the error means.

@tautschnig
Copy link
Member

Good catch. I'm seeing this error in other repos that use the action though, e.g:

Yes, this doesn't seem to be an issue with how you use it. It just makes me wonder about the quality of the action itself. Might just need some engaging with the action to help them improve it.

@zhassan-aws
Copy link
Contributor Author

Created leanprover/lean-action#96 to ask about the error.

@zhassan-aws zhassan-aws merged commit 16fcb23 into model-checking:main Aug 27, 2024
@zhassan-aws zhassan-aws deleted the lean-action branch August 27, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants