-
Notifications
You must be signed in to change notification settings - Fork 735
[auth] Add resource compatibility to debugger (RFC 8707) #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg, just tinits :-)
ptal? @ochafik once we bump the typescript version for modelcontextprotocol/typescript-sdk#664 we can merge in https://github.com/modelcontextprotocol/inspector/pull/537/files to use the SDK function rather than having slightly bespoke logic here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typescript SDK is on 1.13.1 now
* use sdk function * bump typescript sdk
Motivation and Context
We've added RFC 8707 Resource Indicators as part of the MCP spec. There is an inflight change to add this to the Typescript SDK.
This change adds the similar behavior to the inspector in order to facilitate debugging.
This depends on: modelcontextprotocol/typescript-sdk#638
How Has This Been Tested?
Tested against the typescript SDK example server, and also tested against a few live servers (sentry, jira) to make sure it doesn't break.
Breaking Changes
Previously, we didn't care about the
resource
parameter returned in the Protected Resource Metadata. Now, in the debugger (and in the regular flow), we'll throw an exception if the resource does not match the provided server url.Another potential breakage is if an AS rejects the
resource
parameter as invalid, we won't progress through the authorization flow, but we think this is unlikely.Types of changes
Checklist
Additional context