Fix proxy token authentication in npx command #603
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎭 Playwright E2E Test Results✅ 12 passed Details12 tests across 1 suite 📊 View Detailed HTML Report (download artifacts) |
The npx entry point (cli/src/cli.ts) was not generating or passing authentication tokens, causing proxy authentication to fail when using `npx @modelcontextprotocol/inspector@latest`. This change aligns the npx behavior with the local development behavior: - Generate session token using crypto.randomBytes(32) - Pass MCP_PROXY_TOKEN to server via environment - Use correct SERVER_PORT instead of PORT - Build client URL with authentication parameters - Pass URL to client via INSPECTOR_URL environment variable Now both `npm run start` and `npx` commands handle authentication consistently.
felixweinberger
force-pushed
the
fweinberger/npx-cli-fix
branch
from
c5a31dd to
e552377
Compare
|
Fixed with #604 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The npx entry point (cli/src/cli.ts) was not generating or passing
authentication tokens, causing proxy authentication to fail when using
npx @modelcontextprotocol/inspector@latest.This change aligns the npx behavior with the local development behavior:
Now both
npm run startandnpxcommands handle authenticationconsistently.
How Has This Been Tested?
node cli/build/cli.jsrun locally:Breaking Changes
No.
Types of changes
Checklist
Additional context