Skip to content

HttpRequest.Builder customizer for Client transports #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Kehrlann
Copy link
Contributor

@Kehrlann Kehrlann commented Jul 11, 2025

Provide a way to customize HTTP requests before executing them, for both HttpClientSseClientTransport and HttpClientStreamableHttpTransport.

We introduce AsyncHttpRequestCustomizer, which is the core class that does the heavy lifting. For blocking contexts, we provide a simpler SyncHttpRequestCustomizer API, which ultimately gets wrapped. The details of the implementation in both transports is not relevant (yet) ; we are focused on both customizers and also on the transpots, specifically:

  • AsyncHttpRequestCustomizer
  • SyncHttpRequestCustomizer
  • HttpClientSseClientTransport.Builder#requestCustomizer and HttpClientSseClientTransport.Builder#asyncRequestCustomizer
  • HttpClientStreamableHttpTransport.Builder#requestCustomizer and HttpClientStreamableHttpTransport.Builder#asyncRequestCustomizer

Motivation and Context

These are transport-level hooks, to allow users to modify request, e.g. to add security in headers (OAuth2 tokens, API keys, etc).

How Has This Been Tested?

Tested with a Servlet Spring app, using SyncHttpRequestCustomizer.

Breaking Changes

No.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Copy link
Contributor

@tzolov tzolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kehrlann I think this would work.
What about the webflux clients. would we need to expose a similar customizer abstractions there as well?

@Kehrlann
Copy link
Contributor Author

Nice! I’ll tidy up the PR then.

for WebClient-based transport, the WebClient has transformation primitives already (for ex ExchangeFilterFunction), so no need to add an MCP-specific customizer.

@tzolov tzolov mentioned this pull request Jul 22, 2025
@Kehrlann Kehrlann force-pushed the dgarnier/http-request-builder-customzier branch 8 times, most recently from 3929197 to 0bfcc7c Compare July 30, 2025 14:58
@Kehrlann Kehrlann requested a review from tzolov July 30, 2025 15:15
@Kehrlann Kehrlann marked this pull request as ready for review July 30, 2025 15:15
@Kehrlann Kehrlann changed the title DRAFT - HttpRequest.Builder customizer HttpRequest.Builder customizer Jul 30, 2025
@tzolov tzolov added this to the 0.11.0 milestone Jul 30, 2025
- Minor improvement: speed up HttpClientSseClientTransportTests by
  reusing the MCP Server container across tests.
- Minor improvement: rename "messageSink" to "deliveredSink" in
  HttpClientStreamableHttpTransport#sendMessage
@Kehrlann Kehrlann force-pushed the dgarnier/http-request-builder-customzier branch from 0bfcc7c to eeb4837 Compare July 30, 2025 16:31
@Kehrlann Kehrlann changed the title HttpRequest.Builder customizer HttpRequest.Builder customizer for Client transports Jul 30, 2025
@tzolov
Copy link
Contributor

tzolov commented Jul 30, 2025

Thanks @Kehrlann

@tzolov tzolov merged commit ae2fc86 into modelcontextprotocol:main Jul 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants