-
Notifications
You must be signed in to change notification settings - Fork 175
Naming "OpAmpLimited" instead of "ImprovedOpAmpLimited" #4653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
did you miss adding the new file? |
as proposed by @HansOlsson
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
@HansOlsson pls. re-review because @christiankral fixed a mention of the name in the type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
…ding the already merged OpAmp (modelica#4643 and modelica#4653)
Following the advice of @christiankral and @casella (see #4643)