Skip to content

Conversation

AHaumer
Copy link
Contributor

@AHaumer AHaumer commented May 23, 2025

Following the advice of @christiankral and @casella (see #4643)

@AHaumer AHaumer added this to the MSL4.2.0 milestone May 23, 2025
@AHaumer AHaumer self-assigned this May 23, 2025
@AHaumer AHaumer added enhancement New feature or enhancement L: Electrical.Analog Issue addresses Modelica.Electrical.Analog labels May 23, 2025
@HansOlsson
Copy link
Contributor

did you miss adding the new file?

@AHaumer AHaumer requested a review from HansOlsson May 23, 2025 15:30
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@christiankral christiankral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@AHaumer AHaumer requested a review from HansOlsson May 23, 2025 20:56
@AHaumer
Copy link
Contributor Author

AHaumer commented May 23, 2025

@HansOlsson pls. re-review because @christiankral fixed a mention of the name in the type.

@beutlich beutlich added the V: 4.2.0-dev Issue originates in MSL v4.2.0-dev (and is not present in earlier releases) label May 24, 2025
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@AHaumer AHaumer merged commit 9f34063 into modelica:master May 29, 2025
2 checks passed
AHaumer added a commit to AHaumer/ModelicaStandardLibrary that referenced this pull request May 29, 2025
@AHaumer AHaumer added the create new reference results create new reference results label May 29, 2025
@beutlich beutlich removed the request for review from casella June 2, 2025 05:35
AHaumer added a commit to AHaumer/ModelicaStandardLibrary that referenced this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create new reference results create new reference results enhancement New feature or enhancement L: Electrical.Analog Issue addresses Modelica.Electrical.Analog V: 4.2.0-dev Issue originates in MSL v4.2.0-dev (and is not present in earlier releases)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants